Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-10 Thread zhangqing
I really don't care about whatever arbitrary limit people think there is. Please put it on a single line. Hi,Marc Thank you for your reply, I saw it my $max_line_length = 100; So already fixed it in v4:). Thanks, Qing Thanks, M.

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-10 Thread zhangqing
On 03/10/2021 04:47 PM, Sergei Shtylyov wrote: Hello! The new line length limit is 100 chars. :-) Hi,Sergei Thank you for your reply, I saw it my $max_line_length = 100; Soalready fixed it in v4:). Thanks, Qing MBR, Sergei

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-10 Thread Marc Zyngier
On Wed, 10 Mar 2021 02:26:24 +, zhangqing wrote: > > > On 03/09/2021 05:10 PM, Marc Zyngier wrote: > > > >> + > >> +static void __iomem *liointc_get_reg_byname(struct device_node *node, > >> + const char *name) > >> +{ > >> + int index = of_property

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-10 Thread Sergei Shtylyov
Hello! On 10.03.2021 5:26, zhangqing wrote: [...] +    if (of_device_is_compatible(node, "loongson,liointc-2.0")) { +    base = liointc_get_reg_byname(node, "main"); +    if (!base) { +    err = -ENODEV; +    goto out_free_priv; +    } +    for (i = 0; i < LIOINT

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-09 Thread zhangqing
On 03/09/2021 05:10 PM, Marc Zyngier wrote: + +static void __iomem *liointc_get_reg_byname(struct device_node *node, + const char *name) +{ + int index = of_property_match_string(node, "reg-names", name); + + return of_iomap(node, inde

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-09 Thread Marc Zyngier
On Sat, 06 Mar 2021 02:36:31 +, Qing Zhang wrote: > > Add IO interrupt controller support for Loongson 2k1000, different > from the 3a series is that 2K1000 has 64 interrupt sources, 0-31 > correspond to the device tree liointc0 device node, and the other > correspond to liointc1 node. > > S

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-05 Thread Ming Wang
On 03/06/2021 10:36 AM, Qing Zhang wrote: Add IO interrupt controller support for Loongson 2k1000, different from the 3a series is that 2K1000 has 64 interrupt sources, 0-31 correspond to the device tree liointc0 device node, and the other correspond to liointc1 node. Signed-off-by: Jiaxun Yang

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-05 Thread zhangqing
On 03/06/2021 11:06 AM, Huacai Chen wrote: Hi, Qing, On Sat, Mar 6, 2021 at 10:36 AM Qing Zhang wrote: Add IO interrupt controller support for Loongson 2k1000, different from the 3a series is that 2K1000 has 64 interrupt sources, 0-31 correspond to the device tree liointc0 device node, and

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-05 Thread Huacai Chen
Hi, Qing, On Sat, Mar 6, 2021 at 10:36 AM Qing Zhang wrote: > > Add IO interrupt controller support for Loongson 2k1000, different > from the 3a series is that 2K1000 has 64 interrupt sources, 0-31 > correspond to the device tree liointc0 device node, and the other > correspond to liointc1 node.

[PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-05 Thread Qing Zhang
Add IO interrupt controller support for Loongson 2k1000, different from the 3a series is that 2K1000 has 64 interrupt sources, 0-31 correspond to the device tree liointc0 device node, and the other correspond to liointc1 node. Signed-off-by: Jiaxun Yang Signed-off-by: Qing Zhang --- v2-v3: No c