Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu

Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu > --- >

Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu

Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu > --- >

[PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-08 Thread David Wu
Just use the same pwm ops for each IP, and get rid of the ops in the struct of rockchip_pwm_data, but still define the 3 different rockchip_pwm_data to use common interface for each IP. Signed-off-by: David Wu --- drivers/pwm/pwm-rockchip.c | 147

[PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-08 Thread David Wu
Just use the same pwm ops for each IP, and get rid of the ops in the struct of rockchip_pwm_data, but still define the 3 different rockchip_pwm_data to use common interface for each IP. Signed-off-by: David Wu --- drivers/pwm/pwm-rockchip.c | 147 - 1