Re: [PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-11 Thread Stanimir Varbanov
Hi Greg, Thanks for the comments! On 6/9/20 2:12 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:02PM +0300, Stanimir Varbanov wrote: >> +int venus_dbgfs_init(struct venus_core *core) >> +{ >> +core->root = debugfs_create_dir("venus", NULL); >> +if (IS_ERR(core->root)) >> +

Re: [PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-09 Thread Greg Kroah-Hartman
On Tue, Jun 09, 2020 at 01:46:02PM +0300, Stanimir Varbanov wrote: > +int venus_dbgfs_init(struct venus_core *core) > +{ > + core->root = debugfs_create_dir("venus", NULL); > + if (IS_ERR(core->root)) > + return IS_ERR(core->root); You really do not care, and obviously did not

[PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-09 Thread Stanimir Varbanov
This will be useful when debugging specific issues related to firmware HFI interface. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/Makefile| 2 +- drivers/media/platform/qcom/venus/core.c | 5 drivers/media/platform/qcom/venus/core.h | 3 +++