Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-19 Thread Matthias Brugger
On 02/11/2018 09:08 PM, Marcus Folkesson wrote: > watchdog_init_timeout() will allways pick timeout_param since it > defaults to a valid timeout. > > By following best practice described in > Documentation/watchdog/watchdog-kernel-api.txt, it also > let us to set timout-sec property in

Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-19 Thread Matthias Brugger
On 02/11/2018 09:08 PM, Marcus Folkesson wrote: > watchdog_init_timeout() will allways pick timeout_param since it > defaults to a valid timeout. > > By following best practice described in > Documentation/watchdog/watchdog-kernel-api.txt, it also > let us to set timout-sec property in

Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-18 Thread Guenter Roeck
On 02/18/2018 04:08 PM, Rob Herring wrote: On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote: watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. By following best practice described in Documentation/watchdog/watchdog-kernel-api.txt, it

Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-18 Thread Guenter Roeck
On 02/18/2018 04:08 PM, Rob Herring wrote: On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote: watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. By following best practice described in Documentation/watchdog/watchdog-kernel-api.txt, it

Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-18 Thread Rob Herring
On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote: > watchdog_init_timeout() will allways pick timeout_param since it > defaults to a valid timeout. > > By following best practice described in > Documentation/watchdog/watchdog-kernel-api.txt, it also > let us to set timout-sec

Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-18 Thread Rob Herring
On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote: > watchdog_init_timeout() will allways pick timeout_param since it > defaults to a valid timeout. > > By following best practice described in > Documentation/watchdog/watchdog-kernel-api.txt, it also > let us to set timout-sec

[PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-11 Thread Marcus Folkesson
watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. By following best practice described in Documentation/watchdog/watchdog-kernel-api.txt, it also let us to set timout-sec property in devicetree. Signed-off-by: Marcus Folkesson

[PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-11 Thread Marcus Folkesson
watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. By following best practice described in Documentation/watchdog/watchdog-kernel-api.txt, it also let us to set timout-sec property in devicetree. Signed-off-by: Marcus Folkesson Reviewed-by: Guenter