Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

2020-12-15 Thread Hsin-hsiung Wang
Hi, On Tue, 2020-12-15 at 11:56 +, Mark Brown wrote: > On Tue, Dec 15, 2020 at 05:23:08PM +0800, Hsin-hsiung Wang wrote: > > On Tue, 2020-11-24 at 17:07 +, Mark Brown wrote: > > > > This looks like it could just be regmap_get_voltage_sel_regmap()? > > > Otherwise the driver looks good. >

Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

2020-12-15 Thread Mark Brown
On Tue, Dec 15, 2020 at 05:23:08PM +0800, Hsin-hsiung Wang wrote: > On Tue, 2020-11-24 at 17:07 +, Mark Brown wrote: > > This looks like it could just be regmap_get_voltage_sel_regmap()? > > Otherwise the driver looks good. > Thanks for the review. > MT6359 regulator has sel_reg and

Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

2020-12-15 Thread Hsin-hsiung Wang
Hi, On Tue, 2020-11-24 at 17:07 +, Mark Brown wrote: > On Mon, Nov 23, 2020 at 11:48:07AM +0800, Hsin-Hsiung Wang wrote: > > > +static int mt6359_get_linear_voltage_sel(struct regulator_dev *rdev) > > +{ > > + struct mt6359_regulator_info *info = rdev_get_drvdata(rdev); > > + int ret,

Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

2020-11-24 Thread Mark Brown
On Mon, Nov 23, 2020 at 11:48:07AM +0800, Hsin-Hsiung Wang wrote: > +static int mt6359_get_linear_voltage_sel(struct regulator_dev *rdev) > +{ > + struct mt6359_regulator_info *info = rdev_get_drvdata(rdev); > + int ret, regval; > + > + ret = regmap_read(rdev->regmap,

[PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

2020-11-22 Thread Hsin-Hsiung Wang
From: Wen Su The MT6359 is a regulator found on boards based on MediaTek MT6779 and probably other SoCs. It is a so called pmic and connects as a slave to SoC using SPI, wrapped inside the pmic-wrapper. Signed-off-by: Wen Su Signed-off-by: Hsin-Hsiung Wang Acked-by: Mark Brown ---