Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-09-02 Thread Eugen.Hristev
On 31.08.2019 15:17, Wolfram Sang wrote: > >>> + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node, >>> +"i2c-dig-filter"); >>> + >> >> What do you think of the idea to introduce 'flags' to struct i2c_timings >> and parse the bindin

Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-08-31 Thread Wolfram Sang
> > + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node, > > +"i2c-dig-filter"); > > + > > What do you think of the idea to introduce 'flags' to struct i2c_timings > and parse the bindings in the core, too? Then you'd have sth like: >

Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-08-31 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-at91-core.c > b/drivers/i2c/busses/i2c-at91-core.c > index a663a7a..62610af 100644 > --- a/drivers/i2c/busses/i2c-at91-core.c > +++ b/drivers/i2c/busses/i2c-at91-core.c > @@ -68,6 +68,7 @@ static struct at91_twi_pdata at91rm9200_config = { > .has_unre_f

[PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for digital filtering for i2c. The sama5d4, sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 9 + drivers/i2c/busses/i2