Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-17 Thread Bin Liu
On Fri, May 12, 2017 at 04:57:48PM +0300, Peter Ujfalusi wrote: > For the DMA we have ch (channel), dmareq and sync_dev parameters both > within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. one of the two "tusb_omap_dma_ch" should be "tusb_omap_dma". Regards, -Bin.

Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-17 Thread Bin Liu
On Fri, May 12, 2017 at 04:57:48PM +0300, Peter Ujfalusi wrote: > For the DMA we have ch (channel), dmareq and sync_dev parameters both > within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. one of the two "tusb_omap_dma_ch" should be "tusb_omap_dma". Regards, -Bin.

Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-17 Thread Bin Liu
On Fri, May 12, 2017 at 04:57:48PM +0300, Peter Ujfalusi wrote: > For the DMA we have ch (channel), dmareq and sync_dev parameters both > within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. > By creating a common struct the code can be simplified when selecting > between the shared or

Re: [PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-17 Thread Bin Liu
On Fri, May 12, 2017 at 04:57:48PM +0300, Peter Ujfalusi wrote: > For the DMA we have ch (channel), dmareq and sync_dev parameters both > within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. > By creating a common struct the code can be simplified when selecting > between the shared or

[PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-12 Thread Peter Ujfalusi
For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi

[PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-12 Thread Peter Ujfalusi
For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi Tested-by: Tony