Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-29 Thread Fu Wei
Hi Will, As you know, I have moved all the GTDT code to ACPI driver , and simplify the GTDT relevant code in arm_arch_timer.c. That will be in my next patchset. but you can check here : https://git.linaro.org/people/fu.wei/linux.git/shortlog/refs/heads/acpi-topic-sbsa-watchdog_upstream_v4_devel G

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-27 Thread Will Deacon
On Tue, May 26, 2015 at 05:27:33PM +0100, Fu Wei wrote: > On 26 May 2015 at 23:36, Guenter Roeck wrote: > > On Tue, May 26, 2015 at 04:18:42PM +0100, Will Deacon wrote: > >> Sure, the device it describes may only ever exist on ARM systems, but by > >> that logic then we should be moving lots of dr

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Timur Tabi
Hanjun Guo wrote: I don't agree with this. The GTDT should be parsed even if there's no watchdog driver compiled for this kernel. There are no other #ifdefs in this file. So what's the point of parse GTDT and alloc memories for it if there is no watchdog driver compiled for the kernel? I do

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Hanjun Guo
On 2015年05月27日 00:35, Timur Tabi wrote: On 05/26/2015 03:28 AM, Hanjun Guo wrote: early_acpi_os_unmap_memory((char *)table, tbl_size); } please add #ifdef CONFIG_ARM_SBSA_WATCHDOG (acpi gtdt code) #endif I don't agree with this. The GTDT should be parsed even if there's no watchdo

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Guenter Roeck
On Tue, May 26, 2015 at 11:35:19AM -0500, Timur Tabi wrote: > On 05/26/2015 03:28 AM, Hanjun Guo wrote: > > >> early_acpi_os_unmap_memory((char *)table, tbl_size); > >> } > > > >please add > > > >#ifdef CONFIG_ARM_SBSA_WATCHDOG > >(acpi gtdt code) > >#endif > > I don't agree with this. The

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Timur Tabi
On 05/26/2015 03:28 AM, Hanjun Guo wrote: early_acpi_os_unmap_memory((char *)table, tbl_size); } please add #ifdef CONFIG_ARM_SBSA_WATCHDOG (acpi gtdt code) #endif I don't agree with this. The GTDT should be parsed even if there's no watchdog driver compiled for this kernel. Ther

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Fu Wei
On 26 May 2015 at 23:36, Guenter Roeck wrote: > On Tue, May 26, 2015 at 04:18:42PM +0100, Will Deacon wrote: >> On Tue, May 26, 2015 at 04:02:56PM +0100, Ashwin Chaugule wrote: >> > On 26 May 2015 at 08:28, Will Deacon wrote: >> > > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrot

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Ashwin Chaugule
On 26 May 2015 at 11:18, Will Deacon wrote: > On Tue, May 26, 2015 at 04:02:56PM +0100, Ashwin Chaugule wrote: >> On 26 May 2015 at 08:28, Will Deacon wrote: >> > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: >> >> From: Fu Wei >> >> >> >> Parse SBSA Generic Watchdog Structu

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Guenter Roeck
On Tue, May 26, 2015 at 04:18:42PM +0100, Will Deacon wrote: > On Tue, May 26, 2015 at 04:02:56PM +0100, Ashwin Chaugule wrote: > > On 26 May 2015 at 08:28, Will Deacon wrote: > > > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: > > >> From: Fu Wei > > >> > > >> Parse SBSA Gen

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Will Deacon
On Tue, May 26, 2015 at 04:02:56PM +0100, Ashwin Chaugule wrote: > On 26 May 2015 at 08:28, Will Deacon wrote: > > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: > >> From: Fu Wei > >> > >> Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > >> and create a platform

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Ashwin Chaugule
Hi Will, On 26 May 2015 at 08:28, Will Deacon wrote: > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: >> From: Fu Wei >> >> Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, >> and create a platform device with that information. >> This platform device can be used

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Will Deacon
On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: > From: Fu Wei > > Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > and create a platform device with that information. > This platform device can be used by the ARM SBSA Generic > Watchdog driver. > > Tested-by: Su

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Hanjun Guo
Hi Fu Wei, Some minor comments inline. On 2015年05月25日 18:03, fu@linaro.org wrote: From: Fu Wei Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, and create a platform device with that information. This platform device can be used by the ARM SBSA Generic Watchdog driver. Tested

[PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-25 Thread fu . wei
From: Fu Wei Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, and create a platform device with that information. This platform device can be used by the ARM SBSA Generic Watchdog driver. Tested-by: Suravee Suthikulpanit Tested-by: Timur Tabi Signed-off-by: Fu Wei --- arch/arm64/