Re: [PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups

2020-07-13 Thread Valentin Schneider
On 13/07/20 13:39, Peter Zijlstra wrote: > On Wed, Jul 01, 2020 at 08:06:54PM +0100, Valentin Schneider wrote: >> +/* Generate a mask of SD flags with the SDF_NEEDS_GROUPS metaflag */ >> +#define SD_FLAG(name, idx, mflags) (BIT(idx) * (((mflags) & >> SDF_NEEDS_GROUPS) / SDF_NEEDS_GROUPS)) | > >

Re: [PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups

2020-07-13 Thread Peter Zijlstra
On Wed, Jul 01, 2020 at 08:06:54PM +0100, Valentin Schneider wrote: > +/* Generate a mask of SD flags with the SDF_NEEDS_GROUPS metaflag */ > +#define SD_FLAG(name, idx, mflags) (BIT(idx) * (((mflags) & > SDF_NEEDS_GROUPS) / SDF_NEEDS_GROUPS)) | #define SD_FLAGS(name, idx, mflags) (!!((mflags) &

Re: [PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups

2020-07-02 Thread Valentin Schneider
On 02/07/20 19:29, Dietmar Eggemann wrote: > On 01/07/2020 21:06, Valentin Schneider wrote: > > [...] > >> @@ -105,16 +122,18 @@ SD_FLAG(SD_SERIALIZE, 8, SDF_SHARED_PARENT) >> * Place busy tasks earlier in the domain >> * >> * SHARED_CHILD: Usually set on the SMT level. Technicall

Re: [PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups

2020-07-02 Thread Dietmar Eggemann
On 01/07/2020 21:06, Valentin Schneider wrote: [...] > @@ -105,16 +122,18 @@ SD_FLAG(SD_SERIALIZE, 8, SDF_SHARED_PARENT) > * Place busy tasks earlier in the domain > * > * SHARED_CHILD: Usually set on the SMT level. Technically could be set > further > - * up, but currently assum

[PATCH v3 6/7] sched/topology: Introduce SD metaflag for flags needing > 1 groups

2020-07-01 Thread Valentin Schneider
In preparation of cleaning up the sd_degenerate*() functions, mark flags that are only relevant when their associated domain has more than a single group. With this, build a compile-time mask of those SD flags. Suggested-by: Peter Zijlstra Signed-off-by: Valentin Schneider --- include/linux/sch