Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-10 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 6:14 PM, Yinghai Lu wrote: >>> >>> +#include "misc_pgt.c" >> >> Shouldn't this just be a normal built .o file that is linked together >> in the Makefile, specifically tracking CONFIG_RANDOMIZE_BASE as aslr.o >> already is? > > Yes, we could go that way. Please check

Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-10 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 6:14 PM, Yinghai Lu ying...@kernel.org wrote: +#include misc_pgt.c Shouldn't this just be a normal built .o file that is linked together in the Makefile, specifically tracking CONFIG_RANDOMIZE_BASE as aslr.o already is? Yes, we could go that way. Please check

Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-09 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 6:09 PM, Kees Cook wrote: > On Sat, Mar 7, 2015 at 2:07 PM, Yinghai Lu wrote: >> First, aslr will support to put random VO above 4G, so we must set ident >> mapping for the range even we come from startup_32 path. >> >> Second, when boot from 64bit bootloader, bootloader

Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-09 Thread Kees Cook
On Sat, Mar 7, 2015 at 2:07 PM, Yinghai Lu wrote: > First, aslr will support to put random VO above 4G, so we must set ident > mapping for the range even we come from startup_32 path. > > Second, when boot from 64bit bootloader, bootloader set ident mapping, > and boot via ZO

Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-09 Thread Kees Cook
On Sat, Mar 7, 2015 at 2:07 PM, Yinghai Lu ying...@kernel.org wrote: First, aslr will support to put random VO above 4G, so we must set ident mapping for the range even we come from startup_32 path. Second, when boot from 64bit bootloader, bootloader set ident mapping, and boot via ZO

Re: [PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-09 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 6:09 PM, Kees Cook keesc...@chromium.org wrote: On Sat, Mar 7, 2015 at 2:07 PM, Yinghai Lu ying...@kernel.org wrote: First, aslr will support to put random VO above 4G, so we must set ident mapping for the range even we come from startup_32 path. Second, when boot from

[PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-07 Thread Yinghai Lu
First, aslr will support to put random VO above 4G, so we must set ident mapping for the range even we come from startup_32 path. Second, when boot from 64bit bootloader, bootloader set ident mapping, and boot via ZO (arch/x86/boot/compressed/vmlinux) startup_64. Those pages for pagetable need to

[PATCH v3 7/7] x86, kaslr, 64bit: Set new or extra ident_mapping

2015-03-07 Thread Yinghai Lu
First, aslr will support to put random VO above 4G, so we must set ident mapping for the range even we come from startup_32 path. Second, when boot from 64bit bootloader, bootloader set ident mapping, and boot via ZO (arch/x86/boot/compressed/vmlinux) startup_64. Those pages for pagetable need to