Re: [PATCH v3 7/8] media: uvcvideo: Set a different name for the metadata entity

2021-03-12 Thread Ricardo Ribalda Delgado
Hi Laurent Thanks! On Sat, Mar 13, 2021 at 12:29 AM Laurent Pinchart wrote: > > Hi Ricardo, > > On Sat, Mar 13, 2021 at 12:17:50AM +0100, Ricardo Ribalda Delgado wrote: > > On Fri, Mar 12, 2021 at 11:30 PM Laurent Pinchart wrote: > > > On Fri, Mar 12, 2021 at 01:48:29PM +0100, Ricardo Ribalda wro

Re: [PATCH v3 7/8] media: uvcvideo: Set a different name for the metadata entity

2021-03-12 Thread Laurent Pinchart
Hi Ricardo, On Sat, Mar 13, 2021 at 12:17:50AM +0100, Ricardo Ribalda Delgado wrote: > On Fri, Mar 12, 2021 at 11:30 PM Laurent Pinchart wrote: > > On Fri, Mar 12, 2021 at 01:48:29PM +0100, Ricardo Ribalda wrote: > > > All the entities must have a unique name. And now that we are at it, we > > > a

Re: [PATCH v3 7/8] media: uvcvideo: Set a different name for the metadata entity

2021-03-12 Thread Ricardo Ribalda Delgado
HI Laurent Thanks for the review On Fri, Mar 12, 2021 at 11:30 PM Laurent Pinchart wrote: > > Hi Ricardo, > > Thank you for the patch. > > On Fri, Mar 12, 2021 at 01:48:29PM +0100, Ricardo Ribalda wrote: > > All the entities must have a unique name. And now that we are at it, we > > append the e

Re: [PATCH v3 7/8] media: uvcvideo: Set a different name for the metadata entity

2021-03-12 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Fri, Mar 12, 2021 at 01:48:29PM +0100, Ricardo Ribalda wrote: > All the entities must have a unique name. And now that we are at it, we > append the entity->id to the name to avoid collisions on multi-chain > devices. > > Fixes v4l2-compliance: > Media Con

[PATCH v3 7/8] media: uvcvideo: Set a different name for the metadata entity

2021-03-12 Thread Ricardo Ribalda
All the entities must have a unique name. And now that we are at it, we append the entity->id to the name to avoid collisions on multi-chain devices. Fixes v4l2-compliance: Media Controller ioctls: fail: v4l2-test-media.cpp(205): v2_entity_names_set.find(key) != v2_entity_names_se