Re: [PATCH v3 8/7] TESTING_ONLY x86/entry: reduce static footprint of idtentry

* Linus Torvalds wrote: > On Mon, Feb 12, 2018 at 1:37 AM, Ingo Molnar wrote: > > > > Ok, so this does not look _that_ complicated, and the .text savings are > > significant: > > Honestly, I think we should do it. 3kB of assembly code is noticeable. > > Also, that patch actually allows more c

Re: [PATCH v3 8/7] TESTING_ONLY x86/entry: reduce static footprint of idtentry

On Mon, Feb 12, 2018 at 1:37 AM, Ingo Molnar wrote: > > Ok, so this does not look _that_ complicated, and the .text savings are > significant: Honestly, I think we should do it. 3kB of assembly code is noticeable. Also, that patch actually allows more cleanups and simplifications. Look at the "i

Re: [PATCH v3 8/7] TESTING_ONLY x86/entry: reduce static footprint of idtentry

* Dominik Brodowski wrote: > Play a little trick in the generic PUSH_AND_CLEAR_REGS macro > to insert the GP registers "above" the original return address. > This allows us to (re-)insert the macro in error_entry() and > paranoid_entry() and to remove it from the idtentry macro. This > reduces t

[PATCH v3 8/7] TESTING_ONLY x86/entry: reduce static footprint of idtentry

Play a little trick in the generic PUSH_AND_CLEAR_REGS macro to insert the GP registers "above" the original return address. This allows us to (re-)insert the macro in error_entry() and paranoid_entry() and to remove it from the idtentry macro. This reduces the static footprint significantly. NOTE