Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

2015-09-03 Thread Shawn Lin
On 2015/9/4 1:45, Mark Brown wrote: On Thu, Sep 03, 2015 at 09:41:43PM +0800, Shawn Lin wrote: On 2015/9/3 20:54, Mark Brown wrote: If this is a quirk of the DMA controller why is it being fixed with a property specific to the SPI controller? Can't the DMA controller just override the burst

Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

2015-09-03 Thread Mark Brown
On Thu, Sep 03, 2015 at 09:41:43PM +0800, Shawn Lin wrote: > On 2015/9/3 20:54, Mark Brown wrote: > >If this is a quirk of the DMA controller why is it being fixed with a > >property specific to the SPI controller? Can't the DMA controller just > >override the burst size? > Cool...that's a good

Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

2015-09-03 Thread Shawn Lin
On 2015/9/3 20:54, Mark Brown wrote: On Tue, Sep 01, 2015 at 05:58:44PM +0800, Shawn Lin wrote: Generic dma controller on Rockchips' platform cannot support DMAFLUSHP instruction which make dma to flush the req of non-aligned or non-multiple of what we need. That will cause an unrecoverable dma

Re: [PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

2015-09-03 Thread Mark Brown
On Tue, Sep 01, 2015 at 05:58:44PM +0800, Shawn Lin wrote: > Generic dma controller on Rockchips' platform cannot support > DMAFLUSHP instruction which make dma to flush the req of non-aligned > or non-multiple of what we need. That will cause an unrecoverable > dma bus error. The saftest way is t

[PATCH v3 8/9] spi: rockchip: modify DMA max burst to 1

2015-09-01 Thread Shawn Lin
From: Addy Ke Generic dma controller on Rockchips' platform cannot support DMAFLUSHP instruction which make dma to flush the req of non-aligned or non-multiple of what we need. That will cause an unrecoverable dma bus error. The saftest way is to set dma max burst to 1. Signed-off-by: Addy ke F