Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Yonglong Liu
Hi, Russell:     I found this message in kernel log, thanks! On 2020/11/26 1:07, Russell King - ARM Linux admin wrote: On Thu, Nov 26, 2020 at 12:57:37AM +0800, Yonglong Liu wrote: Hi, Antonio:     Could you help to provide a downshift warning message when this happen?     It's a little

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 00:07:56 +0100 Antonio Borneo wrote: > The rtl8211f supports downshift and before commit 5502b218e001 > ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") > the read-back of register MII_CTRL1000 was used to detect the > negotiated link speed. > The code added in

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 12:57:37AM +0800, Yonglong Liu wrote: > Hi, Antonio: > >     Could you help to provide a downshift warning message when this happen? > >     It's a little strange that the adv and the lpa support 1000M, but > finally the link speed is 100M. That is an identifying feature

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Yonglong Liu
Hi, Antonio:     Could you help to provide a downshift warning message when this happen?     It's a little strange that the adv and the lpa support 1000M, but finally the link speed is 100M. Settings for eth5: Supported ports: [ TP ] Supported link modes: 10baseT/Half

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Yonglong Liu
Tested-by: Yonglong Liu On 2020/11/25 7:07, Antonio Borneo wrote: The rtl8211f supports downshift and before commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") the read-back of register MII_CTRL1000 was used to detect the negotiated link speed. The code added

[PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-24 Thread Antonio Borneo
The rtl8211f supports downshift and before commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") the read-back of register MII_CTRL1000 was used to detect the negotiated link speed. The code added in commit d445dff2df60 ("net: phy: realtek: read actual speed to