Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Alexei Starovoitov
On 5/23/18 6:50 PM, Jakub Kicinski wrote: On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Alexei Starovoitov
On 5/23/18 6:50 PM, Jakub Kicinski wrote: On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: > Minor glitch with Ubuntu 18.04: > > $ gcc --version > gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 > > In file included from /usr/include/fcntl.h:290:0, > from ../net/bpfilter/main.c:7: > In function ‘open’, > inlined from

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: > Minor glitch with Ubuntu 18.04: > > $ gcc --version > gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 > > In file included from /usr/include/fcntl.h:290:0, > from ../net/bpfilter/main.c:7: > In function ‘open’, > inlined from

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function ‘open’, inlined from ‘main’ at ../net/bpfilter/main.c:58:13:

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function ‘open’, inlined from ‘main’ at ../net/bpfilter/main.c:58:13:

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Greg KH
On Wed, May 23, 2018 at 01:26:48PM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 21 May 2018 19:22:28 -0700 > > > v2->v3: > > - followed Luis's suggestion and significantly simplied first patch > > with shmem_kernel_file_setup+kernel_write. Added kdoc for

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Greg KH
On Wed, May 23, 2018 at 01:26:48PM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 21 May 2018 19:22:28 -0700 > > > v2->v3: > > - followed Luis's suggestion and significantly simplied first patch > > with shmem_kernel_file_setup+kernel_write. Added kdoc for new helper > > -

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread David Miller
From: Alexei Starovoitov Date: Mon, 21 May 2018 19:22:28 -0700 > v2->v3: > - followed Luis's suggestion and significantly simplied first patch > with shmem_kernel_file_setup+kernel_write. Added kdoc for new helper > - fixed typos and race to access pipes with mutex > - tested

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread David Miller
From: Alexei Starovoitov Date: Mon, 21 May 2018 19:22:28 -0700 > v2->v3: > - followed Luis's suggestion and significantly simplied first patch > with shmem_kernel_file_setup+kernel_write. Added kdoc for new helper > - fixed typos and race to access pipes with mutex > - tested with bpfilter

[PATCH v3 net-next 0/2] bpfilter

2018-05-21 Thread Alexei Starovoitov
Hi All, v2->v3: - followed Luis's suggestion and significantly simplied first patch with shmem_kernel_file_setup+kernel_write. Added kdoc for new helper - fixed typos and race to access pipes with mutex - tested with bpfilter being 'builtin'. CONFIG_BPFILTER_UMH=y|m both work. Interesting to

[PATCH v3 net-next 0/2] bpfilter

2018-05-21 Thread Alexei Starovoitov
Hi All, v2->v3: - followed Luis's suggestion and significantly simplied first patch with shmem_kernel_file_setup+kernel_write. Added kdoc for new helper - fixed typos and race to access pipes with mutex - tested with bpfilter being 'builtin'. CONFIG_BPFILTER_UMH=y|m both work. Interesting to