Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-07 Thread Vladimir Oltean
On Fri, 7 Jun 2019 at 22:15, David Miller wrote: > > From: David Miller > Date: Wed, 05 Jun 2019 11:44:29 -0700 (PDT) > > > From: Vladimir Oltean > > Date: Wed, 5 Jun 2019 12:13:59 +0300 > > > >> It is conflicting because net-next at the moment lacks this patch that > >> I submitted to net: >

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-07 Thread David Miller
From: David Miller Date: Wed, 05 Jun 2019 11:44:29 -0700 (PDT) > From: Vladimir Oltean > Date: Wed, 5 Jun 2019 12:13:59 +0300 > >> It is conflicting because net-next at the moment lacks this patch that >> I submitted to net: >>

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-07 Thread Vladimir Oltean
On Fri, 7 Jun 2019 at 06:32, Richard Cochran wrote: > > On Thu, Jun 06, 2019 at 04:40:19PM +0300, Vladimir Oltean wrote: > > Plain and simply because it doesn't work very well. > > Even phc2sys from the system clock to the hardware (no timestamps > > involved) has trouble staying put (under 1000

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-06 Thread Richard Cochran
On Thu, Jun 06, 2019 at 04:40:19PM +0300, Vladimir Oltean wrote: > Plain and simply because it doesn't work very well. > Even phc2sys from the system clock to the hardware (no timestamps > involved) has trouble staying put (under 1000 ns offset). > And using the hardware-corrected timestamps

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-06 Thread Vladimir Oltean
On Thu, 6 Jun 2019 at 06:11, Richard Cochran wrote: > > On Wed, Jun 05, 2019 at 09:08:54PM +0300, Vladimir Oltean wrote: > > Currently I'm using a cyclecounter, but I *will* need actual PHC > > manipulations for the time-based shaping and policing features that > > the switch has in hardware. > >

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 09:08:54PM +0300, Vladimir Oltean wrote: > Currently I'm using a cyclecounter, but I *will* need actual PHC > manipulations for the time-based shaping and policing features that > the switch has in hardware. Okay. > On the other hand I get much tighter sync > offset using

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread David Miller
From: Vladimir Oltean Date: Wed, 5 Jun 2019 12:13:59 +0300 > On Wed, 5 Jun 2019 at 06:23, David Miller wrote: >> >> From: Vladimir Oltean >> Date: Tue, 4 Jun 2019 20:07:39 +0300 >> >> > This patchset adds the following: >> > >> > - A timecounter/cyclecounter based PHC for the free-running >>

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 20:45, Richard Cochran wrote: > > On Wed, Jun 05, 2019 at 02:33:52PM +0300, Vladimir Oltean wrote: > > In the meantime: Richard, do you have any objections to this patchset? > > I like the fact that you didn't have to change the dsa or ptp > frameworks this time around. I

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 20:50, Vladimir Oltean wrote: > > On Wed, 5 Jun 2019 at 20:45, Richard Cochran wrote: > > > > On Wed, Jun 05, 2019 at 02:33:52PM +0300, Vladimir Oltean wrote: > > > In the meantime: Richard, do you have any objections to this patchset? > > > > I like the fact that you

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 20:45, Richard Cochran wrote: > > On Wed, Jun 05, 2019 at 02:33:52PM +0300, Vladimir Oltean wrote: > > In the meantime: Richard, do you have any objections to this patchset? > > I like the fact that you didn't have to change the dsa or ptp > frameworks this time around. I

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Richard Cochran
On Wed, Jun 05, 2019 at 02:33:52PM +0300, Vladimir Oltean wrote: > In the meantime: Richard, do you have any objections to this patchset? I like the fact that you didn't have to change the dsa or ptp frameworks this time around. I haven't taken a closer look than that yet. > I was wondering

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 12:13, Vladimir Oltean wrote: > > On Wed, 5 Jun 2019 at 06:23, David Miller wrote: > > > > From: Vladimir Oltean > > Date: Tue, 4 Jun 2019 20:07:39 +0300 > > > > > This patchset adds the following: > > > > > > - A timecounter/cyclecounter based PHC for the free-running >

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-05 Thread Vladimir Oltean
On Wed, 5 Jun 2019 at 06:23, David Miller wrote: > > From: Vladimir Oltean > Date: Tue, 4 Jun 2019 20:07:39 +0300 > > > This patchset adds the following: > > > > - A timecounter/cyclecounter based PHC for the free-running > >timestamping clock of this switch. > > > > - A state machine

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-04 Thread David Miller
From: Vladimir Oltean Date: Tue, 4 Jun 2019 20:07:39 +0300 > This patchset adds the following: > > - A timecounter/cyclecounter based PHC for the free-running >timestamping clock of this switch. > > - A state machine implemented in the DSA tagger for SJA1105, which >keeps track of

[PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-04 Thread Vladimir Oltean
This patchset adds the following: - A timecounter/cyclecounter based PHC for the free-running timestamping clock of this switch. - A state machine implemented in the DSA tagger for SJA1105, which keeps track of metadata follow-up Ethernet frames (the switch's way of transmitting RX