Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-25 Thread Mickaël Salaün
On 24/03/2021 21:31, James Morris wrote: > On Fri, 19 Mar 2021, Mickaël Salaün wrote: > >> Cc: Kees Cook Signed-off-by: Mickaël Salaün Acked-by: Serge Hallyn Link: https://lore.kernel.org/r/20210316204252.427806-3-...@digikod.net >>> >>> (Aside: you appear to be self-addin

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-24 Thread James Morris
On Fri, 19 Mar 2021, Mickaël Salaün wrote: > > >> Cc: Kees Cook > >> Signed-off-by: Mickaël Salaün > >> Acked-by: Serge Hallyn > >> Link: https://lore.kernel.org/r/20210316204252.427806-3-...@digikod.net > > > > (Aside: you appear to be self-adding your Link: tags -- AIUI, this is > > normall

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-22 Thread Jann Horn
On Tue, Mar 16, 2021 at 9:43 PM Mickaël Salaün wrote: > A Landlock ruleset is mainly a red-black tree with Landlock rules as > nodes. This enables quick update and lookup to match a requested > access, e.g. to a file. A ruleset is usable through a dedicated file > descriptor (cf. following commi

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-19 Thread Kees Cook
On Fri, Mar 19, 2021 at 08:03:22PM +0100, Mickaël Salaün wrote: > On 19/03/2021 19:40, Kees Cook wrote: > > On Tue, Mar 16, 2021 at 09:42:42PM +0100, Mickaël Salaün wrote: > >> [...] > >> +static void put_rule(struct landlock_rule *const rule) > >> +{ > >> + might_sleep(); > >> + if (!rule) > >>

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-19 Thread Mickaël Salaün
On 19/03/2021 19:40, Kees Cook wrote: > On Tue, Mar 16, 2021 at 09:42:42PM +0100, Mickaël Salaün wrote: >> From: Mickaël Salaün >> >> A Landlock ruleset is mainly a red-black tree with Landlock rules as >> nodes. This enables quick update and lookup to match a requested >> access, e.g. to a fil

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-19 Thread Kees Cook
On Tue, Mar 16, 2021 at 09:42:42PM +0100, Mickaël Salaün wrote: > From: Mickaël Salaün > > A Landlock ruleset is mainly a red-black tree with Landlock rules as > nodes. This enables quick update and lookup to match a requested > access, e.g. to a file. A ruleset is usable through a dedicated fi

[PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-16 Thread Mickaël Salaün
From: Mickaël Salaün A Landlock ruleset is mainly a red-black tree with Landlock rules as nodes. This enables quick update and lookup to match a requested access, e.g. to a file. A ruleset is usable through a dedicated file descriptor (cf. following commit implementing syscalls) which enables a