Re: [PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition

2020-07-16 Thread Dan Murphy
Pavel On 7/16/20 10:03 AM, Dan Murphy wrote: Pavel On 7/16/20 3:31 AM, Pavel Machek wrote: Hi! First, let's substitute multi.color -> multicolor globally, LEDS_CLASS_MULTI_COLOR is most visible example of this. Please also decide whether it is MultiColor or multicolor, and make it consistent.

Re: [PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition

2020-07-16 Thread Dan Murphy
Pavel On 7/16/20 3:31 AM, Pavel Machek wrote: Hi! First, let's substitute multi.color -> multicolor globally, LEDS_CLASS_MULTI_COLOR is most visible example of this. Please also decide whether it is MultiColor or multicolor, and make it consistent. Dictionary definition is multicolor no space

Re: [PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition

2020-07-16 Thread Pavel Machek
Hi! First, let's substitute multi.color -> multicolor globally, LEDS_CLASS_MULTI_COLOR is most visible example of this. Please also decide whether it is MultiColor or multicolor, and make it consistent. > Introduce a multicolor class that groups colored LEDs > within a LED node. > > The multi co

Re: [PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition

2020-07-15 Thread Marek Behún
On Mon, 13 Jul 2020 10:45:33 -0500 Dan Murphy wrote: > Introduce a multicolor class that groups colored LEDs > within a LED node. > > The multi color class groups monochrome LEDs and allows controlling > two aspects of the final combined color: hue and lightness. The > former is controlled via t

[PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition

2020-07-13 Thread Dan Murphy
Introduce a multicolor class that groups colored LEDs within a LED node. The multi color class groups monochrome LEDs and allows controlling two aspects of the final combined color: hue and lightness. The former is controlled via the intensity file and the latter is controlled via brightness file.