Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-24 Thread Jarkko Sakkinen
On Thu, Sep 24, 2020 at 06:00:57PM +0200, Borislav Petkov wrote: > On Thu, Sep 24, 2020 at 03:09:01PM +0300, Jarkko Sakkinen wrote: > > This is not technically SGX specific patch. Is SGX documentation the > > correct place for this? > > So what is it then? It is SGX implementation-specific. Why wo

Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 03:09:01PM +0300, Jarkko Sakkinen wrote: > This is not technically SGX specific patch. Is SGX documentation the > correct place for this? So what is it then? It is SGX implementation-specific. Why would you not put it in the documentation?! > From checkpatch I only get: P

Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-24 Thread Jarkko Sakkinen
On Thu, Sep 24, 2020 at 12:07:12AM +0200, Borislav Petkov wrote: > On Tue, Sep 15, 2020 at 02:28:36PM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > The basic concept and implementation is very similar to the kernel's > > exception fixup mechanism. The key differences are th

Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-23 Thread Borislav Petkov
On Tue, Sep 15, 2020 at 02:28:36PM +0300, Jarkko Sakkinen wrote: > From: Sean Christopherson > > The basic concept and implementation is very similar to the kernel's > exception fixup mechanism. The key differences are that the kernel > handler is hardcoded and the fixup entry addresses are rela

[PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-15 Thread Jarkko Sakkinen
From: Sean Christopherson The basic concept and implementation is very similar to the kernel's exception fixup mechanism. The key differences are that the kernel handler is hardcoded and the fixup entry addresses are relative to the overall table as opposed to individual entries. Hardcoding the

[PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-15 Thread Jarkko Sakkinen
From: Sean Christopherson The basic concept and implementation is very similar to the kernel's exception fixup mechanism. The key differences are that the kernel handler is hardcoded and the fixup entry addresses are relative to the overall table as opposed to individual entries. Hardcoding the