Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-13 Thread Christoph Hellwig
On Mon, Apr 12, 2021 at 08:48:08AM -0700, Darrick J. Wong wrote: > A couple of revisions ago I specifically asked Gustavo to create these > 'silly' sizeof helpers to clean up... > > > > - (sizeof(struct xfs_efd_log_item) + > > > -

Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-12 Thread Gustavo A. R. Silva
On 4/12/21 10:48, Darrick J. Wong wrote: > On Mon, Apr 12, 2021 at 04:29:06PM +0100, Christoph Hellwig wrote: >>> Below are the results of running xfstests for "all" with the following >>> configuration in local.config: >> >> ... >> >>> Other tests might need to be run in order to verify

Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-12 Thread Darrick J. Wong
On Mon, Apr 12, 2021 at 04:29:06PM +0100, Christoph Hellwig wrote: > > Below are the results of running xfstests for "all" with the following > > configuration in local.config: > > ... > > > Other tests might need to be run in order to verify everything is working > > as expected. For such

Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-12 Thread Gustavo A. R. Silva
On 4/12/21 10:29, Christoph Hellwig wrote: >> Below are the results of running xfstests for "all" with the following >> configuration in local.config: > > ... > >> Other tests might need to be run in order to verify everything is working >> as expected. For such tests, the intervention of the

Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-12 Thread Christoph Hellwig
> Below are the results of running xfstests for "all" with the following > configuration in local.config: ... > Other tests might need to be run in order to verify everything is working > as expected. For such tests, the intervention of the maintainers might be > needed. This is a little weird

[PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-12 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].