Re: [PATCH v4] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

On Tue, Aug 15, 2017 at 03:19:54PM +0300, Anton Vasilyev wrote: > If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate > sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() > performs pri_dai->sec_dai dereference in any case. > > The patch removes useless rein

[PATCH v4] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove

If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() performs pri_dai->sec_dai dereference in any case. The patch removes useless reinitialization of sec_dai at samsung_i2s_remove(), because resources are und