Re: [PATCH v4] DAX: enable iostat for read/write

2017-01-11 Thread Kani, Toshimitsu
On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote: > > On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote: > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to users. > > [] > > diff --

Re: [PATCH v4] DAX: enable iostat for read/write

2017-01-10 Thread Joe Perches
On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. [] > diff --git a/fs/dax.c b/fs/dax.c [] > @@ -1058,12 +1058,22 @@ dax_iomap_rw(stru

Re: [PATCH v4] DAX: enable iostat for read/write

2017-01-10 Thread Kani, Toshimitsu
On Tue, 2017-01-10 at 15:41 -0800, Dan Williams wrote: > On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani > wrote: : > > > > +   if (blk_queue_io_stat(disk->queue)) { > > +   int sec = iov_iter_count(iter) >> 9; > > + > > +   start = jiffies; > > +   generic_st

Re: [PATCH v4] DAX: enable iostat for read/write

2017-01-10 Thread Dan Williams
On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still does not su

[PATCH v4] DAX: enable iostat for read/write

2017-01-10 Thread Toshi Kani
DAX IO path does not support iostat, but its metadata IO path does. Therefore, iostat shows metadata IO statistics only, which has been confusing to users. Add iostat support to the DAX read/write path. Note, iostat still does not support the DAX mmap path as it allows user applications to access