Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Brijesh Singh
Hi, >> I have looked at possibility of pushing correctable error logging in the >> firmware; but given current hardware limitation it seems like OS is the best >> place to implement it. Let me summaries the issues we are running into: >> >> * Correctable errors does not generate any interrupt: >>

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Borislav Petkov
On Fri, Oct 30, 2015 at 05:06:06PM +, Mark Rutland wrote: > > * Correctable errors does not generate any interrupt: > > If we have to implement error parsing inside the firmware then work need > > to be split between OS and firmware. Maybe OS can call SMC instruction to > > dial into fir

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Mark Rutland
> > > * Interaction with firmware > > > - When/do we handle interrupts? > > > > We can a properties in dt bindings: > > > > 1) "num-interrupts = 1" - number of interrupt count. One interrupts per > > cluster > > e.g if you have 4 cluster then num-interrupts=4. > > 2) interrupts = <0, 92, 0>

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Mark Rutland
On Fri, Oct 30, 2015 at 11:26:58AM -0500, Brijesh Singh wrote: > Hi Mark, > > >> + > >> +Required properties: > >> +- compatible: Should be "arm,cortex-a57-edac" or "arm,cortex-a53-edac" > >> + > >> +Example: > >> + edac { > >> + compatible = "arm,cortex-a57-edac"; > >> + }; > >> + > >

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-30 Thread Brijesh Singh
Hi Mark, >> + >> +Required properties: >> +- compatible: Should be "arm,cortex-a57-edac" or "arm,cortex-a53-edac" >> + >> +Example: >> +edac { >> +compatible = "arm,cortex-a57-edac"; >> +}; >> + > > This is insufficient for big.LITTLE, no interrupt is possible, and we > haven'

Re: [PATCH v4] EDAC: Add ARM64 EDAC

2015-10-28 Thread Mark Rutland
Hi, On Wed, Oct 28, 2015 at 11:13:49AM -0500, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC: ijc+devicet...@hellion.org.uk > CC: ga...@codeaurora.org > CC:

[PATCH v4] EDAC: Add ARM64 EDAC

2015-10-28 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC: mche...@osg.samsung.com CC: devicet..