Re: [PATCH v4] IBM power meter driver

2007-10-12 Thread Darrick J. Wong
On Tue, Oct 09, 2007 at 08:00:44AM -0400, Mark M. Hoffman wrote: > Sorry it took me so long to get back to this. I've applied this to my hwmon > testing branch, but I would still like to get a review from an IPMI expert. I'm working on finding somebody to do that. > OBTW: please try to send

Re: [PATCH v4] IBM power meter driver

2007-10-12 Thread Darrick J. Wong
On Tue, Oct 09, 2007 at 08:00:44AM -0400, Mark M. Hoffman wrote: Sorry it took me so long to get back to this. I've applied this to my hwmon testing branch, but I would still like to get a review from an IPMI expert. I'm working on finding somebody to do that. OBTW: please try to send

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Darrick J. Wong
On Tue, Oct 09, 2007 at 06:44:07PM +0200, Roel Kluin wrote: > >> + if (IS_ERR(data->hwmon_dev)) { > >> + printk(KERN_ERR DRVNAME ": Error, unable to register hwmon " > >> + "class device for interface %d\n", > >> + data->interface); > >> +

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Roel Kluin
Mark M. Hoffman wrote: >> +static void ibmpex_register_bmc(int iface, struct device *dev) >> +{ >> +struct ibmpex_bmc_data *data; >> +int err; >> + >> +data = kzalloc(sizeof(*data), GFP_KERNEL); >> +if (!data) { >> +printk(KERN_ERR DRVNAME ": Insufficient memory for BMC

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Mark M. Hoffman
Hi Darrick: * Darrick J. Wong <[EMAIL PROTECTED]> [2007-09-14 12:33:46 -0700]: > Here's a fourth revision where I've tried to clean up the things that > people complained about, as well as shifted the sysfs file names to > match the spec that we've been drifting towards. Sorry it took me so long

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Mark M. Hoffman
Hi Darrick: * Darrick J. Wong [EMAIL PROTECTED] [2007-09-14 12:33:46 -0700]: Here's a fourth revision where I've tried to clean up the things that people complained about, as well as shifted the sysfs file names to match the spec that we've been drifting towards. Sorry it took me so long to

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Roel Kluin
Mark M. Hoffman wrote: +static void ibmpex_register_bmc(int iface, struct device *dev) +{ +struct ibmpex_bmc_data *data; +int err; + +data = kzalloc(sizeof(*data), GFP_KERNEL); +if (!data) { +printk(KERN_ERR DRVNAME : Insufficient memory for BMC +

Re: [PATCH v4] IBM power meter driver

2007-10-09 Thread Darrick J. Wong
On Tue, Oct 09, 2007 at 06:44:07PM +0200, Roel Kluin wrote: + if (IS_ERR(data-hwmon_dev)) { + printk(KERN_ERR DRVNAME : Error, unable to register hwmon + class device for interface %d\n, + data-interface); + kfree(data); +

[PATCH v4] IBM power meter driver

2007-09-14 Thread Darrick J. Wong
Here's a fourth revision where I've tried to clean up the things that people complained about, as well as shifted the sysfs file names to match the spec that we've been drifting towards. --- ibm_pex: Driver to export IBM PowerExecutive power meter sensors. Signed-off-by: Darrick J. Wong <[EMAIL

[PATCH v4] IBM power meter driver

2007-09-14 Thread Darrick J. Wong
Here's a fourth revision where I've tried to clean up the things that people complained about, as well as shifted the sysfs file names to match the spec that we've been drifting towards. --- ibm_pex: Driver to export IBM PowerExecutive power meter sensors. Signed-off-by: Darrick J. Wong [EMAIL