Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-09-04 Thread Coly Li
On 2017/9/5 上午10:37, Byungchul Park wrote: > On Fri, Aug 18, 2017 at 02:04:20PM +0800, Coly Li wrote: >> On 2017/8/18 上午9:24, Byungchul Park wrote: >>> On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: Although llist provides proper APIs, they are not used. Make them used. >>> >>

Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-09-04 Thread Byungchul Park
On Fri, Aug 18, 2017 at 02:04:20PM +0800, Coly Li wrote: > On 2017/8/18 上午9:24, Byungchul Park wrote: > > On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: > >> Although llist provides proper APIs, they are not used. Make them used. > > > > Any opinions about this? > > > > The patc

Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-08-17 Thread Byungchul Park
On Fri, Aug 18, 2017 at 02:04:20PM +0800, Coly Li wrote: > On 2017/8/18 上午9:24, Byungchul Park wrote: > > On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: > >> Although llist provides proper APIs, they are not used. Make them used. > > > > Any opinions about this? > > > > The patc

Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-08-17 Thread Coly Li
On 2017/8/18 上午9:24, Byungchul Park wrote: > On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: >> Although llist provides proper APIs, they are not used. Make them used. > > Any opinions about this? > The patch is good. If Eric has no time, I will take care of it later. Thanks. C

Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-08-17 Thread Byungchul Park
On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. Any opinions about this? > > Signed-off-by: Byungchul Park > Acked-by: Coly Li > --- > drivers/md/bcache/closure.c | 15 ++- > 1 file changed,

[PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

2017-08-10 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park Acked-by: Coly Li --- drivers/md/bcache/closure.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c