On Mon, Jun 08, 2020 at 11:48:24AM +0200, Markus Elfring wrote:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig
>
> How does this feedback fit to remaining typos in the change description?
> Do you care for any further improvements of the commit message
> besides the discussed tag “Fixes”?
On Mon, Jun 08, 2020 at 11:48:24AM +0200, Markus Elfring wrote:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig
>
> How does this feedback fit to remaining typos in the change description?
> Do you care for any further improvements of the commit message
> besides the discussed tag “Fixes”?
> Looks good,
>
> Reviewed-by: Christoph Hellwig
How does this feedback fit to remaining typos in the change description?
Do you care for any further improvements of the commit message
besides the discussed tag “Fixes”?
Regards,
Markus
On Mon, Jun 8, 2020 at 8:52 AM Sedat Dilek wrote:
>
> On Mon, Jun 8, 2020 at 8:47 AM Sedat Dilek wrote:
> >
> > On Mon, Jun 8, 2020 at 8:18 AM Christoph Hellwig wrote:
> > >
> > > Looks good,
> > >
> > > Reviewed-by: Christoph Hellwig
> > >
> > > Can you dig into the history for a proper fixes
On Mon, Jun 8, 2020 at 8:47 AM Sedat Dilek wrote:
>
> On Mon, Jun 8, 2020 at 8:18 AM Christoph Hellwig wrote:
> >
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig
> >
> > Can you dig into the history for a proper fixes tag?
>
> [ CC Dan ]
>
> Dan gave the hint for the Fixes: tag in reply t
On Mon, Jun 8, 2020 at 8:18 AM Christoph Hellwig wrote:
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig
>
> Can you dig into the history for a proper fixes tag?
[ CC Dan ]
Dan gave the hint for the Fixes: tag in reply to the first patch:
> The Fixes tag is a good idea though:
>
> Fixes: 89e
Hi Christoph,
在 2020/6/8 14:15, Christoph Hellwig 写道:
Looks good,
Reviewed-by: Christoph Hellwig
Can you dig into the history for a proper fixes tag?
This one started to accessing bdev after __blkdev_get(). So I think it
may be a proper fixes tag:
Fixes: e525fd89d380 ("block: make blkde
Looks good,
Reviewed-by: Christoph Hellwig
Can you dig into the history for a proper fixes tag?
In blkdev_get() we call __blkdev_get() to do some internal jobs and if
there is some errors in __blkdev_get(), the bdput() is called which
means we have released the refcount of the bdev (actually the refcount of
the bdev inode). This means we cannot access bdev after that point. But
acctually bdev
9 matches
Mail list logo