Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-10 Thread Shuah Khan
On Tue, 2012-10-09 at 14:02 -0700, Andrew Morton wrote: > On Mon, 08 Oct 2012 11:07:20 -0600 > Shuah Khan wrote: > > > > > > > Still seems overly complicated to me, but whatev. > > > > > > I think the way to handle this is pretty simple: set a flag in the dma > > > entry when someone runs dma_m

Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-09 Thread Andrew Morton
On Mon, 08 Oct 2012 11:07:20 -0600 Shuah Khan wrote: > > > > Still seems overly complicated to me, but whatev. > > > > I think the way to handle this is pretty simple: set a flag in the dma > > entry when someone runs dma_mapping_error() and, if that flag wasn't > > set at unmap time, emit a lo

Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-08 Thread Shuah Khan
On Fri, 2012-10-05 at 15:51 -0700, Andrew Morton wrote: > > Still seems overly complicated to me, but whatev. > > I think the way to handle this is pretty simple: set a flag in the dma > entry when someone runs dma_mapping_error() and, if that flag wasn't > set at unmap time, emit a loud warning

Re: [PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-05 Thread Andrew Morton
On Thu, 04 Oct 2012 19:23:13 -0600 Shuah Khan wrote: > A recent dma mapping error analysis effort showed that a large percentage > of dma_map_single() and dma_map_page() returns are not checked for mapping > errors. > > Reference: > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_E

[PATCH v4] dma-debug: New interfaces to debug dma mapping errors

2012-10-04 Thread Shuah Khan
A recent dma mapping error analysis effort showed that a large percentage of dma_map_single() and dma_map_page() returns are not checked for mapping errors. Reference: http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis Adding support for tracking dma mapping and unmappin