Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Joel Stanley
Hey Greg, On Sat, Feb 11, 2017 at 1:00 AM, Greg KH wrote: > On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: >> In order to manage server systems, there is typically another processor >> known as a BMC (Baseboard Management Controller) which is responsible

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Joel Stanley
Hey Greg, On Sat, Feb 11, 2017 at 1:00 AM, Greg KH wrote: > On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: >> In order to manage server systems, there is typically another processor >> known as a BMC (Baseboard Management Controller) which is responsible >> for powering the server

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Benjamin Herrenschmidt
On Wed, 2017-02-08 at 10:42 +1100, Cyril Bur wrote: > +struct aspeed_lpc_ctrl_mapping { > +   __u8window_type; > +   __u8window_id; > +   __u16   flags; > +   __u32   addr; > +   __u32   offset; > +   __u32   size; > +}; > + Please document the fields Cheers, Ben.

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Benjamin Herrenschmidt
On Wed, 2017-02-08 at 10:42 +1100, Cyril Bur wrote: > +struct aspeed_lpc_ctrl_mapping { > +   __u8window_type; > +   __u8window_id; > +   __u16   flags; > +   __u32   addr; > +   __u32   offset; > +   __u32   size; > +}; > + Please document the fields Cheers, Ben.

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Benjamin Herrenschmidt
On Fri, 2017-02-10 at 15:30 +0100, Greg KH wrote: > > Without some other reviewed-by: or at least tested-by lines here, I'm > not going to take this.  Go poke your fellow ppc people to do some > work > here, it shouldn't be up to me to do it for them :( We are reviewing it ;-) We asked for a

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Benjamin Herrenschmidt
On Fri, 2017-02-10 at 15:30 +0100, Greg KH wrote: > > Without some other reviewed-by: or at least tested-by lines here, I'm > not going to take this.  Go poke your fellow ppc people to do some > work > here, it shouldn't be up to me to do it for them :( We are reviewing it ;-) We asked for a

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Patrick Williams
On Fri, Feb 10, 2017 at 03:30:12PM +0100, Greg KH wrote: > On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: > > Signed-off-by: Cyril Bur > > --- > > Without some other reviewed-by: or at least tested-by lines here, I'm > not going to take this. Go poke your fellow

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Patrick Williams
On Fri, Feb 10, 2017 at 03:30:12PM +0100, Greg KH wrote: > On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: > > Signed-off-by: Cyril Bur > > --- > > Without some other reviewed-by: or at least tested-by lines here, I'm > not going to take this. Go poke your fellow ppc people to do

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Greg KH
On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: > In order to manage server systems, there is typically another processor > known as a BMC (Baseboard Management Controller) which is responsible > for powering the server and other various elements, sometimes fans, > often the system

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-10 Thread Greg KH
On Wed, Feb 08, 2017 at 10:42:47AM +1100, Cyril Bur wrote: > In order to manage server systems, there is typically another processor > known as a BMC (Baseboard Management Controller) which is responsible > for powering the server and other various elements, sometimes fans, > often the system

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Benjamin Herrenschmidt
On Wed, 2017-02-08 at 02:06 +0200, Andy Shevchenko wrote: > > On Wed, Feb 8, 2017 at 1:42 AM, Cyril Bur wrote: > > In order to manage server systems, there is typically another processor > > known as a BMC (Baseboard Management Controller) which is responsible > > for powering

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Benjamin Herrenschmidt
On Wed, 2017-02-08 at 02:06 +0200, Andy Shevchenko wrote: > > On Wed, Feb 8, 2017 at 1:42 AM, Cyril Bur wrote: > > In order to manage server systems, there is typically another processor > > known as a BMC (Baseboard Management Controller) which is responsible > > for powering the server and

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Andy Shevchenko
On Wed, Feb 8, 2017 at 1:42 AM, Cyril Bur wrote: > In order to manage server systems, there is typically another processor > known as a BMC (Baseboard Management Controller) which is responsible > for powering the server and other various elements, sometimes fans, > often the

Re: [PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Andy Shevchenko
On Wed, Feb 8, 2017 at 1:42 AM, Cyril Bur wrote: > In order to manage server systems, there is typically another processor > known as a BMC (Baseboard Management Controller) which is responsible > for powering the server and other various elements, sometimes fans, > often the system flash. > >

[PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Cyril Bur
In order to manage server systems, there is typically another processor known as a BMC (Baseboard Management Controller) which is responsible for powering the server and other various elements, sometimes fans, often the system flash. The Aspeed BMC family which is what is used on OpenPOWER

[PATCH v4] drivers/misc: Add Aspeed LPC control driver

2017-02-07 Thread Cyril Bur
In order to manage server systems, there is typically another processor known as a BMC (Baseboard Management Controller) which is responsible for powering the server and other various elements, sometimes fans, often the system flash. The Aspeed BMC family which is what is used on OpenPOWER