Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dmitry Torokhov
On Wed, Feb 27, 2013 at 10:58:44AM -0700, Mathieu Poirier wrote: > On 13-02-27 09:57 AM, Linus Torvalds wrote: > > On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie wrote: > >> > >> It looks to me like the weak bit isn't working so well > >> > >> if (platform_sysrq_reset_seq) { > >>

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread David Howells
Linus Torvalds wrote: > > Your fix is compiling, running and yielding the correct results - > > apologies about that. > > > > Acked-by: Mathieu Poirier > > Ok, good. Committed and pushed out. Adding rmk and dhowells to the cc > just to let them know, since Dave said they were debugging this on

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Linus Torvalds
On Wed, Feb 27, 2013 at 9:58 AM, Mathieu Poirier wrote: > > Your fix is compiling, running and yielding the correct results - > apologies about that. > > Acked-by: Mathieu Poirier Ok, good. Committed and pushed out. Adding rmk and dhowells to the cc just to let them know, since Dave said they

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Mathieu Poirier
On 13-02-27 09:57 AM, Linus Torvalds wrote: > On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie wrote: >> >> It looks to me like the weak bit isn't working so well >> >> if (platform_sysrq_reset_seq) { >> for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) { >>

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Linus Torvalds
On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie wrote: > > It looks to me like the weak bit isn't working so well > > if (platform_sysrq_reset_seq) { > for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) { > key = platform_sysrq_reset_seq[i]; > 6d:

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) { key = platform_sysrq_reset_seq[i]; 6d: 66 8b 8c 00 00 00 00mov

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
On Wed, Feb 27, 2013 at 9:06 PM, Dave Airlie wrote: > On Wed, Feb 27, 2013 at 6:26 PM, Dave Airlie wrote: >>> >>> this patch seems to be oopsing on my x86 32-bit machine on bootup, pic >>> attached. >>> >>> .config attached. >>> >>> It looks to me like the weak bit isn't working so well >>> >>>

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
On Wed, Feb 27, 2013 at 6:26 PM, Dave Airlie wrote: >> >> this patch seems to be oopsing on my x86 32-bit machine on bootup, pic >> attached. >> >> .config attached. >> >> It looks to me like the weak bit isn't working so well >> >> if (platform_sysrq_reset_seq) { >> for

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
> > this patch seems to be oopsing on my x86 32-bit machine on bootup, pic > attached. > > .config attached. > > It looks to me like the weak bit isn't working so well > > if (platform_sysrq_reset_seq) { > for (i = 0; i < ARRAY_SIZE(sysrq_reset_seq); i++) { >

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
this patch seems to be oopsing on my x86 32-bit machine on bootup, pic attached. .config attached. It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i = 0; i ARRAY_SIZE(sysrq_reset_seq); i++) {

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
On Wed, Feb 27, 2013 at 6:26 PM, Dave Airlie airl...@gmail.com wrote: this patch seems to be oopsing on my x86 32-bit machine on bootup, pic attached. .config attached. It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
On Wed, Feb 27, 2013 at 9:06 PM, Dave Airlie airl...@gmail.com wrote: On Wed, Feb 27, 2013 at 6:26 PM, Dave Airlie airl...@gmail.com wrote: this patch seems to be oopsing on my x86 32-bit machine on bootup, pic attached. .config attached. It looks to me like the weak bit isn't working so

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dave Airlie
It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i = 0; i ARRAY_SIZE(sysrq_reset_seq); i++) { key = platform_sysrq_reset_seq[i]; 6d: 66 8b 8c 00 00 00 00mov0x0(%eax,%eax,1),%cx 74:

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Linus Torvalds
On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie airl...@gmail.com wrote: It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i = 0; i ARRAY_SIZE(sysrq_reset_seq); i++) { key = platform_sysrq_reset_seq[i];

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Mathieu Poirier
On 13-02-27 09:57 AM, Linus Torvalds wrote: On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie airl...@gmail.com wrote: It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) { for (i = 0; i ARRAY_SIZE(sysrq_reset_seq); i++) {

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Linus Torvalds
On Wed, Feb 27, 2013 at 9:58 AM, Mathieu Poirier mathieu.poir...@linaro.org wrote: Your fix is compiling, running and yielding the correct results - apologies about that. Acked-by: Mathieu Poirier mathieu.poir...@linaro.org Ok, good. Committed and pushed out. Adding rmk and dhowells to the

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread David Howells
Linus Torvalds torva...@linux-foundation.org wrote: Your fix is compiling, running and yielding the correct results - apologies about that. Acked-by: Mathieu Poirier mathieu.poir...@linaro.org Ok, good. Committed and pushed out. Adding rmk and dhowells to the cc just to let them know,

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2013-02-27 Thread Dmitry Torokhov
On Wed, Feb 27, 2013 at 10:58:44AM -0700, Mathieu Poirier wrote: On 13-02-27 09:57 AM, Linus Torvalds wrote: On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie airl...@gmail.com wrote: It looks to me like the weak bit isn't working so well if (platform_sysrq_reset_seq) {

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-11-18 Thread Dmitry Torokhov
Hi Mathieu, On Sun, Nov 11, 2012 at 01:24:48PM -0700, mathieu.poir...@linaro.org wrote: > From: "Mathieu J. Poirier" > > This patch adds keyreset functionality to the sysrq driver. It > allows certain button/key combinations to be used in order to > trigger device resets. > > The first time

Re: [PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-11-18 Thread Dmitry Torokhov
Hi Mathieu, On Sun, Nov 11, 2012 at 01:24:48PM -0700, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets.

[PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-11-11 Thread mathieu . poirier
From: "Mathieu J. Poirier" This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets. The first time the key-combo is detected a work function that syncs the filesystems is scheduled and the kernel

[PATCH v4] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-11-11 Thread mathieu . poirier
From: Mathieu J. Poirier mathieu.poir...@linaro.org This patch adds keyreset functionality to the sysrq driver. It allows certain button/key combinations to be used in order to trigger device resets. The first time the key-combo is detected a work function that syncs the filesystems is scheduled