Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-06 Thread Chanwoo Choi
Ping. Hi Rob, I add some comment about gpio-keys and extcon-gpio. I'm waiting for your reply. On 2016년 05월 31일 23:34, Chanwoo Choi wrote: > Hi Rob, > > On Tue, May 31, 2016 at 10:35 PM, Rob Herring wrote: >> On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-06 Thread Chanwoo Choi
Ping. Hi Rob, I add some comment about gpio-keys and extcon-gpio. I'm waiting for your reply. On 2016년 05월 31일 23:34, Chanwoo Choi wrote: > Hi Rob, > > On Tue, May 31, 2016 at 10:35 PM, Rob Herring wrote: >> On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: >>> Hi Rob, >>> >>> On 2016년

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-01 Thread Rob Herring
On Wed, Jun 1, 2016 at 9:49 AM, Laxman Dewangan wrote: > > On Tuesday 31 May 2016 09:18 PM, Rob Herring wrote: >> >> On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan >> wrote: >>> >>> Hi Rob, >>> >>> On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote:

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-01 Thread Rob Herring
On Wed, Jun 1, 2016 at 9:49 AM, Laxman Dewangan wrote: > > On Tuesday 31 May 2016 09:18 PM, Rob Herring wrote: >> >> On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan >> wrote: >>> >>> Hi Rob, >>> >>> On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: On Tue, May 31, 2016 at 2:35 AM,

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-01 Thread Laxman Dewangan
On Tuesday 31 May 2016 09:18 PM, Rob Herring wrote: On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan wrote: Hi Rob, On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: The extcon-gpio.c

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-06-01 Thread Laxman Dewangan
On Tuesday 31 May 2016 09:18 PM, Rob Herring wrote: On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan wrote: Hi Rob, On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: The extcon-gpio.c driver can separate the kind of external connector

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Rob Herring
On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan wrote: > Hi Rob, > > On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: >> >> On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi >> wrote: >>> >>> The extcon-gpio.c driver can separate the kind of external

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Rob Herring
On Tue, May 31, 2016 at 8:44 AM, Laxman Dewangan wrote: > Hi Rob, > > On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: >> >> On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi >> wrote: >>> >>> The extcon-gpio.c driver can separate the kind of external connector >>> by using the 'extcon-id'

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
Hi Rob, On Tue, May 31, 2016 at 10:35 PM, Rob Herring wrote: > On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: >> Hi Rob, >> >> On 2016년 05월 31일 15:44, Chanwoo Choi wrote: >>> On 2016년 05월 28일 00:29, Rob Herring wrote: On Thu, May 26, 2016 at

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
Hi Rob, On Tue, May 31, 2016 at 10:35 PM, Rob Herring wrote: > On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: >> Hi Rob, >> >> On 2016년 05월 31일 15:44, Chanwoo Choi wrote: >>> On 2016년 05월 28일 00:29, Rob Herring wrote: On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Laxman Dewangan
Hi Rob, On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: The extcon-gpio.c driver can separate the kind of external connector by using the 'extcon-id' property. This use of DT is just broken. Come up with another

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Laxman Dewangan
Hi Rob, On Tuesday 31 May 2016 07:05 PM, Rob Herring wrote: On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: The extcon-gpio.c driver can separate the kind of external connector by using the 'extcon-id' property. This use of DT is just broken. Come up with another way. Can we have

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Rob Herring
On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: > Hi Rob, > > On 2016년 05월 31일 15:44, Chanwoo Choi wrote: >> On 2016년 05월 28일 00:29, Rob Herring wrote: >>> On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: Add the support for Device tree bindings

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Rob Herring
On Tue, May 31, 2016 at 2:35 AM, Chanwoo Choi wrote: > Hi Rob, > > On 2016년 05월 31일 15:44, Chanwoo Choi wrote: >> On 2016년 05월 28일 00:29, Rob Herring wrote: >>> On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: Add the support for Device tree bindings of extcon-gpio driver.

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
Hi Rob, On 2016년 05월 31일 15:44, Chanwoo Choi wrote: > On 2016년 05월 28일 00:29, Rob Herring wrote: >> On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: >>> Add the support for Device tree bindings of extcon-gpio driver. >>> The extcon-gpio device tree node must include the both

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
Hi Rob, On 2016년 05월 31일 15:44, Chanwoo Choi wrote: > On 2016년 05월 28일 00:29, Rob Herring wrote: >> On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: >>> Add the support for Device tree bindings of extcon-gpio driver. >>> The extcon-gpio device tree node must include the both

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
- >> From: Chanwoo Choi [mailto:cwcho...@gmail.com] >> Sent: Thursday, May 26, 2016 6:52 PM >> To: Venkat Reddy Talla >> Cc: MyungJoo Ham; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; >> devicetree; Kumar Gala; linux-kernel; Laxman Dewangan >> Subject

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
- >> From: Chanwoo Choi [mailto:cwcho...@gmail.com] >> Sent: Thursday, May 26, 2016 6:52 PM >> To: Venkat Reddy Talla >> Cc: MyungJoo Ham; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; >> devicetree; Kumar Gala; linux-kernel; Laxman Dewangan >> Subject

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
On 2016년 05월 28일 00:29, Rob Herring wrote: > On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: >> Add the support for Device tree bindings of extcon-gpio driver. >> The extcon-gpio device tree node must include the both 'extcon-id' and >> 'gpios' property. > > I think extcon

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-31 Thread Chanwoo Choi
On 2016년 05월 28일 00:29, Rob Herring wrote: > On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: >> Add the support for Device tree bindings of extcon-gpio driver. >> The extcon-gpio device tree node must include the both 'extcon-id' and >> 'gpios' property. > > I think extcon

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-27 Thread Rob Herring
On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: > Add the support for Device tree bindings of extcon-gpio driver. > The extcon-gpio device tree node must include the both 'extcon-id' and > 'gpios' property. I think extcon bindings are a mess in general... > For example: >

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-27 Thread Rob Herring
On Thu, May 26, 2016 at 05:17:45PM +0530, Venkat Reddy Talla wrote: > Add the support for Device tree bindings of extcon-gpio driver. > The extcon-gpio device tree node must include the both 'extcon-id' and > 'gpios' property. I think extcon bindings are a mess in general... > For example: >

RE: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Venkat Reddy Talla
; To: Venkat Reddy Talla > Cc: MyungJoo Ham; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > devicetree; Kumar Gala; linux-kernel; Laxman Dewangan > Subject: Re: [PATCH v4] extcon: gpio: Add the support for Device tree > bindings > > Hi Venkat, > > There is some misco

RE: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Venkat Reddy Talla
; To: Venkat Reddy Talla > Cc: MyungJoo Ham; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > devicetree; Kumar Gala; linux-kernel; Laxman Dewangan > Subject: Re: [PATCH v4] extcon: gpio: Add the support for Device tree > bindings > > Hi Venkat, > > There is some misco

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Chanwoo Choi
Hi Venkat, There is some miscommunication. On previous my reply, I don't mean that the author of the patch[1] is changed from me to you. I'd like you to remain the original author(me) for the patch[1] without changing the author. [1] https://lkml.org/lkml/2015/10/21/8 - [PATCH v3] extcon: gpio:

Re: [PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Chanwoo Choi
Hi Venkat, There is some miscommunication. On previous my reply, I don't mean that the author of the patch[1] is changed from me to you. I'd like you to remain the original author(me) for the patch[1] without changing the author. [1] https://lkml.org/lkml/2015/10/21/8 - [PATCH v3] extcon: gpio:

[PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Venkat Reddy Talla
Add the support for Device tree bindings of extcon-gpio driver. The extcon-gpio device tree node must include the both 'extcon-id' and 'gpios' property. For example: usb_cable: extcon-gpio-0 { compatible = "extcon-gpio"; extcon-id = ; gpios

[PATCH v4] extcon: gpio: Add the support for Device tree bindings

2016-05-26 Thread Venkat Reddy Talla
Add the support for Device tree bindings of extcon-gpio driver. The extcon-gpio device tree node must include the both 'extcon-id' and 'gpios' property. For example: usb_cable: extcon-gpio-0 { compatible = "extcon-gpio"; extcon-id = ; gpios