Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

And there is en[namelen] = '\0', should fix namelen to its right value. On 2017/12/23 11:35, Chao Yu wrote: On 2017/12/23 11:19, Yunlong Song wrote: Double free problem: Since ddr bit jump makes i_namelen a larger value (> 255)，when file is not encrypted, the convert_encrypted_name will memcpy

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

And there is en[namelen] = '\0', should fix namelen to its right value. On 2017/12/23 11:35, Chao Yu wrote: On 2017/12/23 11:19, Yunlong Song wrote: Double free problem: Since ddr bit jump makes i_namelen a larger value (> 255)，when file is not encrypted, the convert_encrypted_name will memcpy

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

On 2017/12/23 11:19, Yunlong Song wrote: > Double free problem: > Since ddr bit jump makes i_namelen a larger value (> 255)，when file is > not encrypted, > the convert_encrypted_name will memcpy out range of en[255], when en is > freed, there > will be double free problem. It looks there is

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

On 2017/12/23 11:19, Yunlong Song wrote: > Double free problem: > Since ddr bit jump makes i_namelen a larger value (> 255)，when file is > not encrypted, > the convert_encrypted_name will memcpy out range of en[255], when en is > freed, there > will be double free problem. It looks there is

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

Double free problem: Since ddr bit jump makes i_namelen a larger value (> 255)，when file is not encrypted, the convert_encrypted_name will memcpy out range of en[255], when en is freed, there will be double free problem. On 2017/12/23 11:05, Chao Yu wrote: On 2017/12/18 21:25, Yunlong Song

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

Double free problem: Since ddr bit jump makes i_namelen a larger value (> 255)，when file is not encrypted, the convert_encrypted_name will memcpy out range of en[255], when en is freed, there will be double free problem. On 2017/12/23 11:05, Chao Yu wrote: On 2017/12/18 21:25, Yunlong Song

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

On 2017/12/18 21:25, Yunlong Song wrote: > v1 -> v2: use child_info to pass dentry namelen > v2 -> v3: check child != NULL to include the F2FS_FT_ORPHAN file type > v3 -> v4: fix the i_namelen problem of dump.f2fs、 There is no commit log, so what do you mean about "avoid double free"? Other than

Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

On 2017/12/18 21:25, Yunlong Song wrote: > v1 -> v2: use child_info to pass dentry namelen > v2 -> v3: check child != NULL to include the F2FS_FT_ORPHAN file type > v3 -> v4: fix the i_namelen problem of dump.f2fs、 There is no commit log, so what do you mean about "avoid double free"? Other than

[PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

v1 -> v2: use child_info to pass dentry namelen v2 -> v3: check child != NULL to include the F2FS_FT_ORPHAN file type v3 -> v4: fix the i_namelen problem of dump.f2fs Signed-off-by: Yunlong Song --- fsck/fsck.c | 28 +++- fsck/fsck.h | 3 ++- 2

[PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double free

v1 -> v2: use child_info to pass dentry namelen v2 -> v3: check child != NULL to include the F2FS_FT_ORPHAN file type v3 -> v4: fix the i_namelen problem of dump.f2fs Signed-off-by: Yunlong Song --- fsck/fsck.c | 28 +++- fsck/fsck.h | 3 ++- 2 files changed, 25