Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-11 Thread Bin Gao
On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote: > > + gpiochip_irqchip_add(&wg->chip, &wcove_irqchip, 0, > > +handle_simple_irq, IRQ_TYPE_NONE); > > Reexamine the use of handle_simple_irq() here. We have two kinds of > irq hardware: those with one r

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-06 Thread Bin Gao
On Wed, Jul 06, 2016 at 01:07:15PM +0300, Mika Westerberg wrote: > On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote: > > On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao wrote: > > > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > > This driver is based on gp

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-06 Thread Bin Gao
On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote: > > +static irqreturn_t wcove_gpio_irq_handler(int irq, void *data) > > +{ > > + int pending; > > + unsigned int p0, p1, virq, gpio; > > + struct wcove_gpio *wg = data; > > + > > + if (regmap_read(wg->regmap, IRQ

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-06 Thread Mika Westerberg
On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote: > On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. > > > > Signed-off-by: Ajay Thomas > > Signed-off-by: Bi

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-06 Thread Linus Walleij
On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao > --- > Changes in v4: > - Converted CTLI_INTCNT_XX macros to less ve

Re: [PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-07-01 Thread Andy Shevchenko
On Tue, Jun 28, 2016 at 2:56 AM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. There are still minors, though they would be fixed later. FWIW: Reviewed-by: Andy Shevchenko > > Signed-off-by: Ajay Thomas >

[PATCH v4] gpio: add Intel WhiskeyCove GPIO driver

2016-06-27 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- Changes in v4: - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX. - Add comments about why there is no .