Re: [PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-25 Thread Jisheng Zhang
Dear Andy On Mon, 25 Apr 2016 12:07:15 +0300 Andy Shevchenko wrote: > On Fri, 2016-04-22 at 16:59 +0300, Jarkko Nikula wrote: > > Hi > > > > On 04/22/2016 11:49 AM, Jisheng Zhang wrote: > > > > > > If i2c_dw_probe() fails, we should disable and unprepare the clock, > > > otherwise the clock

Re: [PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-25 Thread Andy Shevchenko
On Fri, 2016-04-22 at 16:59 +0300, Jarkko Nikula wrote: > Hi > > On 04/22/2016 11:49 AM, Jisheng Zhang wrote: > > > > If i2c_dw_probe() fails, we should disable and unprepare the clock, > > otherwise the clock enable and prepare is left unbalanced. > > > > In dw_i2c_plat_remove(), we'd better to

Re: [PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-22 Thread Jarkko Nikula
Hi On 04/22/2016 11:49 AM, Jisheng Zhang wrote: If i2c_dw_probe() fails, we should disable and unprepare the clock, otherwise the clock enable and prepare is left unbalanced. In dw_i2c_plat_remove(), we'd better to not rely on runtime PM to disable and unprepare the clock since CONFIG_PM may be

[PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

2016-04-22 Thread Jisheng Zhang
If i2c_dw_probe() fails, we should disable and unprepare the clock, otherwise the clock enable and prepare is left unbalanced. In dw_i2c_plat_remove(), we'd better to not rely on runtime PM to disable and unprepare the clock since CONFIG_PM may be disabled when configuring the kernel. So we explic