Re: [PATCH v4] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-14 Thread Jessica Yu
+++ YueHaibing [11/06/19 23:00 +0800]: In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing Applied, thanks. Jessica

Re: [PATCH v4] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-12 Thread Miroslav Benes
On Tue, 11 Jun 2019, YueHaibing wrote: > In module_add_modinfo_attrs if sysfs_create_file > fails, we forget to free allocated modinfo_attrs > and roll back the sysfs files. > > Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") > Signed-off-by: YueHaibing Reviewed-by: Mi

[PATCH v4] kernel/module: Fix mem leak in module_add_modinfo_attrs

2019-06-11 Thread YueHaibing
In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- v4: call module_remove_modinfo_attrs only while i > 0 v3: reuse