Re: [PATCH v4] media: si2168: Refactor command setup code

On Mon, Aug 19, 2019 at 01:54:53PM +0200, Marc Gonzalez wrote: > On 15/07/2019 11:50, Marc Gonzalez wrote: > > > Use cmd_init() to fill a struct si2168_cmd command. > > > > Signed-off-by: Marc Gonzalez > > --- > > Changes from v1: > > - Use a real function to populate struct si2168_cmd *cmd, and

Re: [PATCH v4] media: si2168: Refactor command setup code

On 15/07/2019 11:50, Marc Gonzalez wrote: > Use cmd_init() to fill a struct si2168_cmd command. > > Signed-off-by: Marc Gonzalez > --- > Changes from v1: > - Use a real function to populate struct si2168_cmd *cmd, and a trivial > macro wrapping it (macro because sizeof). > Changes from v2: > - F

[PATCH v4] media: si2168: Refactor command setup code

Use cmd_init() to fill a struct si2168_cmd command. Signed-off-by: Marc Gonzalez --- Changes from v1: - Use a real function to populate struct si2168_cmd *cmd, and a trivial macro wrapping it (macro because sizeof). Changes from v2: - Fix header mess - Add Jonathan's tag Changes from v3: - Drop J