Re: 答复: 答复: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-07 Thread Lee Jones
On Tue, 05 Sep 2017, Lee Jones wrote: > On Tue, 05 Sep 2017, 冯锐 wrote: > > > > > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int > > > > +active) { > > > > + struct rtsx_cr_option *option = &(pcr->option); > > > > + > > > > + u32 interrupt = rtsx_pci_readl(pcr, RTS

Re: 答复: 答复: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-05 Thread Lee Jones
On Tue, 05 Sep 2017, 冯锐 wrote: > > > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int > > > +active) { > > > + struct rtsx_cr_option *option = &(pcr->option); > > > + > > > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR); > > > + int card_exist = (interrupt & SD_EXIST) | (inter

答复: 答复: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-05 Thread 冯锐
> > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int > > +active) { > > + struct rtsx_cr_option *option = &(pcr->option); > > + > > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR); > > + int card_exist = (interrupt & SD_EXIST) | (interrupt & MS_EXIST); > > + int aspm_L1_

Re: 答复: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-05 Thread Lee Jones
On Tue, 05 Sep 2017, 冯锐 wrote: > Dear Jones, > > > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int > > +active) { > > + struct rtsx_cr_option *option = &(pcr->option); > > + > > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR); > > + int card_exist = (interrupt & SD_EXI

答复: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-04 Thread 冯锐
Dear Jones, > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int > +active) { > + struct rtsx_cr_option *option = &(pcr->option); > + > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR); > + int card_exist = (interrupt & SD_EXIST) | (interrupt & MS_EXIST); > + int

Re: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-04 Thread Lee Jones
On Thu, 24 Aug 2017, rui_f...@realsil.com.cn wrote: > From: rui_feng > > Signed-off-by: Rui Feng > --- > drivers/mfd/rts5249.c| 154 + > drivers/mfd/rtsx_pcr.c | 177 > +-- > drivers/mfd/rtsx_pcr.h

Re: [PATCH v4] mfd: Add support for RTS5250S power saving

2017-09-04 Thread Lee Jones
On Thu, 24 Aug 2017, rui_f...@realsil.com.cn wrote: > From: rui_feng You need to write a commit log here. Why is this change required? What does it achieve? Why have you done it this way? What effect does it have? Etc ... > Signed-off-by: Rui Feng > --- > drivers/mfd/rts5249.c| 1

[PATCH v4] mfd: Add support for RTS5250S power saving

2017-08-24 Thread rui_feng
From: rui_feng Signed-off-by: Rui Feng --- drivers/mfd/rts5249.c| 154 + drivers/mfd/rtsx_pcr.c | 177 +-- drivers/mfd/rtsx_pcr.h | 12 +++ include/linux/mfd/rtsx_pci.h | 85 +