On Tue, 09 Aug 2016, SF Markus Elfring wrote:
> > But the change-log in this patch says "I did some stuff".
> > What stuff did you change? Which review comments did you
> > tend to?
>
> I imagine that I could increase the description granularity
> to a detail level which you might also not like.
> But the change-log in this patch says "I did some stuff".
> What stuff did you change? Which review comments did you
> tend to?
I imagine that I could increase the description granularity
to a detail level which you might also not like.
+put_device:
+ platform_device_put(pdev);
>>>
On Mon, 08 Aug 2016, SF Markus Elfring wrote:
> >> v4: Further feedback was integrated into this message.
> >
> > This is not a good change-log. What actually changed?
>
> Which kind of information would you find more useful in this case?
That's for you to tell me surely?
If I wanted to know
>> v4: Further feedback was integrated into this message.
>
> This is not a good change-log. What actually changed?
Which kind of information would you find more useful in this case?
>> @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client
>> *client, const char *name,
>>
On Fri, 01 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
Please use `git send-email` to submit your patches.
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the end.
>
> Signed-off-by: Markus Elf
From: Markus Elfring
Adjust jump targets according to the Linux coding style convention.
Another check for the variable "status" can be omitted then at the end.
Signed-off-by: Markus Elfring
---
v4: Further feedback was integrated into this message.
v3: Deletion of another blank line
v2: Rebasi
6 matches
Mail list logo
