Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-07-09 Thread Rafael J. Wysocki
On Wed, Jun 10, 2020 at 11:21 PM Enric Balletbo i Serra wrote: > > Hi Rafael, > > Many thanks for your feedback. See my answers inline. > > On 5/6/20 13:17, Rafael J. Wysocki wrote: > > On Tuesday, April 14, 2020 4:35:38 PM CEST Enric Balletbo i Serra wrote: > >> Hi Rafael, > >> > >> On 13/4/20

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-07-09 Thread Rafael J. Wysocki
> >>>> a...@infradead.org; ayman.baga...@gmail.com; > >>>> benjamin.tissoi...@redhat.com; > >>>> b...@mxxn.io; dvh...@infradead.org; gre...@linuxfoundation.org; > >>>> hdego...@redhat.com; jer...@system76.com; 2...@mok.nu; > >>

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-07-09 Thread Enric Balletbo i Serra
..@linuxfoundation.org; >>>> hdego...@redhat.com; jer...@system76.com; 2...@mok.nu; >>>> mchehab+sams...@kernel.org; raja...@google.com; >>>> srinivas.pandruv...@linux.intel.com; platform-driver-...@vger.kernel.org >>>> Subject: Re: [PATCH v4] platform: x86: Add ACPI driv

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-23 Thread Enric Balletbo i Serra
Hi Rafael, On 6/6/20 20:04, Dmitry Torokhov wrote: > Hi Rafael, > > On Fri, Jun 05, 2020 at 01:17:15PM +0200, Rafael J. Wysocki wrote: >> >> First off, GGL0001 is not a valid ACPI device ID, because the GGL prefix is >> not >> present in the list at https://uefi.org/acpi_id_list >> True, this

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-11 Thread Enric Balletbo i Serra
aja...@google.com; >>> srinivas.pandruv...@linux.intel.com; platform-driver-...@vger.kernel.org >>> Subject: Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS >>> >>> >>> [EXTERNAL EMAIL] >>> >>> On Wed, Jun 10, 2020 at 09:28:36PM

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Dmitry Torokhov
; benjamin.tissoi...@redhat.com; > > b...@mxxn.io; dvh...@infradead.org; gre...@linuxfoundation.org; > > hdego...@redhat.com; jer...@system76.com; 2...@mok.nu; > > mchehab+sams...@kernel.org; raja...@google.com; > > srinivas.pandruv...@linux.intel.com; platform-driver-

RE: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Mario.Limonciello
edhat.com; jer...@system76.com; 2...@mok.nu; > mchehab+sams...@kernel.org; raja...@google.com; > srinivas.pandruv...@linux.intel.com; platform-driver-...@vger.kernel.org > Subject: Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS > > > [EXTERNAL EMAIL] > > On Wed, Jun

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Dmitry Torokhov
On Wed, Jun 10, 2020 at 09:28:36PM +, mario.limoncie...@dell.com wrote: > > > > To give you some references, if I'm not wrong, this prefix is used in all > > or > > almost all Intel Chromebook devices (auron, cyan, eve, fizz, hatch, > > octopus, > > poppy, strago ...) The ACPI source for this

RE: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Mario.Limonciello
bsson; Mauro > Carvalho Chehab; Rajat Jain; Srinivas Pandruvada; platform-driver- > x...@vger.kernel.org > Subject: Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS > > > [EXTERNAL EMAIL] > > Hi Rafael, > > Many thanks for your feedback. See my a

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Enric Balletbo i Serra
Hi Rafael, Many thanks for your feedback. See my answers inline. On 5/6/20 13:17, Rafael J. Wysocki wrote: > On Tuesday, April 14, 2020 4:35:38 PM CEST Enric Balletbo i Serra wrote: >> Hi Rafael, >> >> On 13/4/20 22:41, Rafael J. Wysocki wrote: >>> On Mon, Apr 13, 2020 at 3:46 PM Enric Balletbo

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-06 Thread Dmitry Torokhov
Hi Rafael, On Fri, Jun 05, 2020 at 01:17:15PM +0200, Rafael J. Wysocki wrote: > > First off, GGL0001 is not a valid ACPI device ID, because the GGL prefix is > not > present in the list at https://uefi.org/acpi_id_list > > There are two ways to address that. One would be to take the GOOG

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-05 Thread Rafael J. Wysocki
On Tuesday, April 14, 2020 4:35:38 PM CEST Enric Balletbo i Serra wrote: > Hi Rafael, > > On 13/4/20 22:41, Rafael J. Wysocki wrote: > > On Mon, Apr 13, 2020 at 3:46 PM Enric Balletbo i Serra > > wrote: > >> > >> This driver attaches to the ChromeOS ACPI device and then exports the > >> values

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-05 Thread Rafael J. Wysocki
On Monday, April 13, 2020 4:12:59 PM CEST Greg Kroah-Hartman wrote: > Meta-comment to the ACPI developers, shouldn't all of this happen > "automatically" with the existing ACPI entries in sysfs? I'm not quite sure what you mean by "all of this" here. Can you please explain? > If not, is this