Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-24 Thread Andy Shevchenko
On Tue, May 17, 2016 at 1:59 AM, Darren Hart wrote: > On Mon, May 16, 2016 at 03:45:50PM +0530, Rajneesh Bhardwaj wrote: >> On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: >> > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj >> >

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-24 Thread Andy Shevchenko
On Tue, May 17, 2016 at 1:59 AM, Darren Hart wrote: > On Mon, May 16, 2016 at 03:45:50PM +0530, Rajneesh Bhardwaj wrote: >> On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: >> > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj >> > wrote: >> > > +INTEL PMC CORE DRIVER >> > >

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-20 Thread dbasehore .
On Thu, May 12, 2016 at 6:50 AM, Rajneesh Bhardwaj wrote: > > + * pmc_dev contains info about power management controller device. > + */ > +struct pmc_dev { > + u32 base_addr; > + void __iomem *regmap; > +#if IS_ENABLED(CONFIG_DEBUG_FS) > + struct

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-20 Thread dbasehore .
On Thu, May 12, 2016 at 6:50 AM, Rajneesh Bhardwaj wrote: > > + * pmc_dev contains info about power management controller device. > + */ > +struct pmc_dev { > + u32 base_addr; > + void __iomem *regmap; > +#if IS_ENABLED(CONFIG_DEBUG_FS) > + struct dentry *dbgfs_dir; > +#endif /*

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-16 Thread Darren Hart
On Mon, May 16, 2016 at 03:45:50PM +0530, Rajneesh Bhardwaj wrote: > On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: > > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj > > wrote: > > > > Sorry for a bit late review, but I think there are still

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-16 Thread Darren Hart
On Mon, May 16, 2016 at 03:45:50PM +0530, Rajneesh Bhardwaj wrote: > On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: > > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj > > wrote: > > > > Sorry for a bit late review, but I think there are still issues need > > to be

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-16 Thread Rajneesh Bhardwaj
On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj > wrote: > > Sorry for a bit late review, but I think there are still issues need > to be addressed. > Thanks for the detailed review and the

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-16 Thread Rajneesh Bhardwaj
On Thu, May 12, 2016 at 06:02:45PM +0300, Andy Shevchenko wrote: > On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj > wrote: > > Sorry for a bit late review, but I think there are still issues need > to be addressed. > Thanks for the detailed review and the feedback. :) > > This patch adds

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-12 Thread Andy Shevchenko
On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj wrote: Sorry for a bit late review, but I think there are still issues need to be addressed. > This patch adds the Power Management Controller driver as a pci driver > for Intel Core SOC architecture. SOC -> SoC >

Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-12 Thread Andy Shevchenko
On Thu, May 12, 2016 at 4:50 PM, Rajneesh Bhardwaj wrote: Sorry for a bit late review, but I think there are still issues need to be addressed. > This patch adds the Power Management Controller driver as a pci driver > for Intel Core SOC architecture. SOC -> SoC > > This driver can utilize

[PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-12 Thread Rajneesh Bhardwaj
This patch adds the Power Management Controller driver as a pci driver for Intel Core SOC architecture. This driver can utilize debugging capabilities and supported features as exposed by the Power Management Controller. Please refer to the below specification for more details on PMC features.

[PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

2016-05-12 Thread Rajneesh Bhardwaj
This patch adds the Power Management Controller driver as a pci driver for Intel Core SOC architecture. This driver can utilize debugging capabilities and supported features as exposed by the Power Management Controller. Please refer to the below specification for more details on PMC features.