Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-05 Thread Qais Yousef
On 08/05/20 19:13, Dongdong Yang wrote: > Appreciate Qais for your clamp implementation. I would like to add traces > for uclamp_rq_util_with and feedback you if I run into any issues. Thanks. FYI, top posting in LKML is frowned upon. Please put your answer underneath the quoted text. > > The u

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-05 Thread Qais Yousef
On 08/05/20 03:33, Dongdong Yang wrote: > Appreciate Qais for your above comments. I believe the clamp is very good for > terminal devices per pid or cgroup setting. I really hope it works for the > extended scenario, "screen off", although it has a potential side effect on > "screen on" response b

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-04 Thread Randy Dunlap
On 8/4/20 12:50 AM, Dongdong Yang wrote: > From: Dongdong Yang > > --- > > diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu > b/Documentation/ABI/testing/sysfs-devices-system-cpu > index b555df8..e299418 100644 > --- a/Documentation/ABI/testing/sysfs-devices-system-cpu > +++ b/Do

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-04 Thread Qais Yousef
Hi Dongdong On 08/04/20 15:50, Dongdong Yang wrote: > +What:/sys/devices/system/cpu/sched_usf > + /sys/devices/system/cpu/sched_usf/sched_usf_non_ux_r > + /sys/devices/system/cpu/sched_usf/sched_usf_up_l0_r > + /sys/devices/system/cpu/sched_usf/s

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-04 Thread peterz
On Tue, Aug 04, 2020 at 03:50:35PM +0800, Dongdong Yang wrote: > +What:/sys/devices/system/cpu/sched_usf > + /sys/devices/system/cpu/sched_usf/sched_usf_non_ux_r > + /sys/devices/system/cpu/sched_usf/sched_usf_up_l0_r > + /sys/devices/system/cpu/

Re: [PATCH v4] sched: Provide USF for the portable equipment.

2020-08-04 Thread Greg KH
On Tue, Aug 04, 2020 at 03:50:35PM +0800, Dongdong Yang wrote: Comments on code stuff only, not if this is actually a valid thing to be doing at all: > --- /dev/null > +++ b/kernel/sched/usf.c > @@ -0,0 +1,294 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 XiaoMi Inc. >

[PATCH v4] sched: Provide USF for the portable equipment.

2020-08-04 Thread Dongdong Yang
From: Dongdong Yang The power consumption and UI response are more cared for by the portable equipment users. USF(User Sensitive Feedback factor) auxiliary cpufreq governor is providing more utils adjustment settings to the high level by scenario identification. >From the view of portable equipm