Re: [PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-16 Thread Calvin Walton
On Fri, 2021-04-16 at 06:42 -0500, Terry Bowman wrote: > > Hi Calvin, > > Thanks for the feedback. I'll begin making the change and testing. > I'll > respond with V2 patch in this thread. > > Regards, > Terry It looks like there might already be a patch in the pipeline for this issue; see Chen

Re: [PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-16 Thread Terry Bowman
Hi Calvin, Thanks for the feedback. I'll begin making the change and testing. I'll respond with V2 patch in this thread. Regards, Terry On 4/14/21 9:13 PM, Calvin Walton wrote: On Tue, 2021-03-30 at 21:38 +, Terry Bowman wrote: +int idx_valid_amd(int idx) +{ +   switch (idx) { + 

Re: [PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-04-14 Thread Calvin Walton
On Tue, 2021-03-30 at 21:38 +, Terry Bowman wrote: > > +int idx_valid_amd(int idx) > +{ > +   switch (idx) { > +   case IDX_PKG_ENERGY: > +   return do_rapl & MSR_PKG_ENERGY_STAT; This isn't correct - MSR_PKG_ENERGY_STAT is the MSR offset, not a bit mask for the do_rapl bi

[PATCH v4] tools/power turbostat: Fix RAPL summary collection on AMD processors

2021-03-30 Thread Terry Bowman
Turbostat fails to correctly collect and display RAPL summary information on Family 17h and 19h AMD processors. Running turbostat on these processors returns immediately. If turbostat is working correctly then RAPL summary data is displayed until the user provided command completes. If a command is