Re: [PATCH v4] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-25 Thread kbuild test robot
Hi Aditya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v5.1-rc2 next-20190325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-25 Thread kbuild test robot
Hi Aditya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v5.1-rc2 next-20190325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-25 Thread kbuild test robot
Hi Aditya, Thank you for the patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v5.1-rc2 next-20190325] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-24 Thread Andy Shevchenko
On Sun, Mar 24, 2019 at 6:43 PM Aditya Pakki wrote: > > pci_ioremap_bar could fail. The patch returns in case of failure to > acquire IOMEM. It also releases the acquired resource in the exit path. This is good per se, but I'm so sorry I found another missed place. When DMA ->probe() fails, we

[PATCH v4] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-24 Thread Aditya Pakki
pci_ioremap_bar could fail. The patch returns in case of failure to acquire IOMEM. It also releases the acquired resource in the exit path. Signed-off-by: Aditya Pakki --- v3: Change the order of pci_iounmap and dw_dma_remove v2: Failed to release resource in exit path and incorrect code in non