Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-09 Thread Richard Leitner
On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ? > > Does it make any sense? >

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: From: Richard Leitner

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 08:20 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, An

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: > On 02/08/2017 08:20 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > > > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > > > O

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > On 02/08/2017 02:59 PM, Greg KH wrote: > > > > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > > > > > On

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > On 02/08/2017 02:59 PM, Greg KH wrote: > > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > > > On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > > > > From: Richard Leitner > > > > > > If you want to fix the

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 02:59 PM, Greg KH wrote: > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: >> On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: >>> From: Richard Leitner >> >> If you want to fix the above you have to fix your Git configuration. My git config is fine, just c

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > > From: Richard Leitner > > If you want to fix the above you have to fix your Git configuration. > > > > This patch adds a driver for configuration of the Microchip > >

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Andy Shevchenko
On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: > From: Richard Leitner If you want to fix the above you have to fix your Git configuration. > This patch adds a driver for configuration of the Microchip > USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity,

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Greg KH
On Wed, Feb 08, 2017 at 09:58:48AM +0100, Richard Leitner wrote: > On 02/08/2017 09:52 AM, Richard Leitner wrote: > > From: Richard Leitner > > Please drop/ignore that "From". This patch is from: > Richard Leitner v5? :)

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 09:52 AM, Richard Leitner wrote: > From: Richard Leitner Please drop/ignore that "From". This patch is from: Richard Leitner > > This patch adds a driver for configuration of the Microchip USB251xB/xBi > USB 2.0 hub controller series with USB 2.0 upstream connectivity, SM

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
From: Richard Leitner This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. Furthermore add myself as a maintainer for this driver. The da