Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Jorge Ramirez
On 9/6/19 19:40, Bjorn Andersson wrote: > On Thu 05 Sep 14:00 PDT 2019, Jorge Ramirez-Ortiz wrote: >> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > [..] >> +static inline int qcom_get_enable(struct watchdog_device *wdd) >> +{ >> +int enable = QCOM_WDT_ENABLE; >> + >>

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Guenter Roeck
On Fri, Sep 06, 2019 at 10:40:09AM -0700, Bjorn Andersson wrote: > On Thu 05 Sep 14:00 PDT 2019, Jorge Ramirez-Ortiz wrote: > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > [..] > > +static inline int qcom_get_enable(struct watchdog_device *wdd) > > +{ > > + int enable

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Bjorn Andersson
On Thu 05 Sep 14:00 PDT 2019, Jorge Ramirez-Ortiz wrote: > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c [..] > +static inline int qcom_get_enable(struct watchdog_device *wdd) > +{ > + int enable = QCOM_WDT_ENABLE; > + > + if (wdd->info->options & WDIOF_PRETIMEOUT)

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Jorge Ramirez
>>> static const u32 reg_offset_data_apcs_tmr[] = { [WDT_RST] = 0x38, [WDT_EN] = 0x40, @@ -54,15 +58,38 @@ struct qcom_wdt *to_qcom_wdt(struct watchdog_device *wdd) return container_of(wdd, struct qcom_wdt, wdd); } +static inline int qcom

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Guenter Roeck
On Thu, Sep 05, 2019 at 11:34:03PM +0200, Jorge Ramirez wrote: > On 9/5/19 23:19, Guenter Roeck wrote: > > On Thu, Sep 05, 2019 at 11:00:35PM +0200, Jorge Ramirez-Ortiz wrote: > >> Use the bark interrupt as the pre-timeout notifier whenever this > >> interrupt is available. > >> > >> By default, th

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez
On 9/5/19 23:19, Guenter Roeck wrote: > On Thu, Sep 05, 2019 at 11:00:35PM +0200, Jorge Ramirez-Ortiz wrote: >> Use the bark interrupt as the pre-timeout notifier whenever this >> interrupt is available. >> >> By default, the pretimeout notification shall occur one second earlier >> than the timeou

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Guenter Roeck
On Thu, Sep 05, 2019 at 11:00:35PM +0200, Jorge Ramirez-Ortiz wrote: > Use the bark interrupt as the pre-timeout notifier whenever this > interrupt is available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > > Signed-off-by: Jorge Ramirez-Ortiz

[PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-05 Thread Jorge Ramirez-Ortiz
Use the bark interrupt as the pre-timeout notifier whenever this interrupt is available. By default, the pretimeout notification shall occur one second earlier than the timeout. Signed-off-by: Jorge Ramirez-Ortiz --- v4: address Guenter Roeck comments as follows: remove unnecessary