Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Sargun Dhillon
On Thu, Nov 12, 2020 at 12:30:56AM +, Sargun Dhillon wrote: > On Wed, Nov 11, 2020 at 08:03:18PM +, Trond Myklebust wrote: > > On Wed, 2020-11-11 at 18:57 +, Sargun Dhillon wrote: > > > On Wed, Nov 11, 2020 at 02:38:11PM +, Trond Myklebust wrote: > > > > On Wed, 2020-11-11 at 11:12

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Sargun Dhillon
On Wed, Nov 11, 2020 at 08:03:18PM +, Trond Myklebust wrote: > On Wed, 2020-11-11 at 18:57 +, Sargun Dhillon wrote: > > On Wed, Nov 11, 2020 at 02:38:11PM +, Trond Myklebust wrote: > > > On Wed, 2020-11-11 at 11:12 +, Sargun Dhillon wrote: > > > > > > The current code for setting s

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Trond Myklebust
On Wed, 2020-11-11 at 18:57 +, Sargun Dhillon wrote: > On Wed, Nov 11, 2020 at 02:38:11PM +, Trond Myklebust wrote: > > On Wed, 2020-11-11 at 11:12 +, Sargun Dhillon wrote: > > > On Tue, Nov 10, 2020 at 08:12:01PM +, Trond Myklebust wrote: > > > > On Tue, 2020-11-10 at 17:43 +0100,

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Sargun Dhillon
On Wed, Nov 11, 2020 at 02:38:11PM +, Trond Myklebust wrote: > On Wed, 2020-11-11 at 11:12 +, Sargun Dhillon wrote: > > On Tue, Nov 10, 2020 at 08:12:01PM +, Trond Myklebust wrote: > > > On Tue, 2020-11-10 at 17:43 +0100, Alban Crequy wrote: > > > > Hi, > > > > > > > > I tested the pat

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Trond Myklebust
On Wed, 2020-11-11 at 11:12 +, Sargun Dhillon wrote: > On Tue, Nov 10, 2020 at 08:12:01PM +, Trond Myklebust wrote: > > On Tue, 2020-11-10 at 17:43 +0100, Alban Crequy wrote: > > > Hi, > > > > > > I tested the patches on top of 5.10.0-rc3+ and I could mount an > > > NFS > > > share with a

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-11 Thread Sargun Dhillon
On Tue, Nov 10, 2020 at 08:12:01PM +, Trond Myklebust wrote: > On Tue, 2020-11-10 at 17:43 +0100, Alban Crequy wrote: > > Hi, > > > > I tested the patches on top of 5.10.0-rc3+ and I could mount an NFS > > share with a different user namespace. fsopen() is done in the > > container namespaces

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-10 Thread Trond Myklebust
On Tue, 2020-11-10 at 17:43 +0100, Alban Crequy wrote: > Hi, > > I tested the patches on top of 5.10.0-rc3+ and I could mount an NFS > share with a different user namespace. fsopen() is done in the > container namespaces (user, mnt and net namespaces) while fsconfig(), > fsmount() and move_mount()

Re: [PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-10 Thread Alban Crequy
Hi, I tested the patches on top of 5.10.0-rc3+ and I could mount an NFS share with a different user namespace. fsopen() is done in the container namespaces (user, mnt and net namespaces) while fsconfig(), fsmount() and move_mount() are done on the host namespaces. The mount on the host is availabl

[PATCH v4 0/2] NFS: Fix interaction between fs_context and user namespaces

2020-11-02 Thread Sargun Dhillon
This is effectively a resend, but re-based atop Anna's current tree. I can add the samples back in an another patchset. Right now, it is possible to mount NFS with an non-matching super block user ns, and NFS sunrpc user ns. This (for the user) results in an awkward set of interactions if using an