Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sören Brinkmann
Hi Grant, On Thu, 2014-02-20 at 11:29AM +, Grant Likely wrote: > On Thu, Feb 20, 2014 at 8:39 AM, Sachin Kamat wrote: > > Hi Grant, > > > > I observe the following boot failure with today's (next-20140220) linux-next > > tree on Exynos based boards with the default exynos_defconfig. > > Ugh,

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Grant Likely
On Thu, 20 Feb 2014 18:12:40 +0800, Kevin Hao wrote: > On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: > > Hi Grant, > > > > I observe the following boot failure with today's (next-20140220) linux-next > > tree on Exynos based boards with the default exynos_defconfig. > > Does this

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Grant Likely
On Thu, Feb 20, 2014 at 8:39 AM, Sachin Kamat wrote: > Hi Grant, > > I observe the following boot failure with today's (next-20140220) linux-next > tree on Exynos based boards with the default exynos_defconfig. Ugh, nested locking. that is not good. Kevin's patch looks correct and I'll merge it i

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
On 20 February 2014 16:25, Kevin Hao wrote: > On Thu, Feb 20, 2014 at 03:57:07PM +0530, Sachin Kamat wrote: >> Hi Kevin, >> >> On 20 February 2014 15:42, Kevin Hao wrote: >> > On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: >> >> Hi Grant, >> >> >> >> I observe the following boot fa

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Kevin Hao
On Thu, Feb 20, 2014 at 03:57:07PM +0530, Sachin Kamat wrote: > Hi Kevin, > > On 20 February 2014 15:42, Kevin Hao wrote: > > On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: > >> Hi Grant, > >> > >> I observe the following boot failure with today's (next-20140220) > >> linux-next >

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
Hi Kevin, On 20 February 2014 15:42, Kevin Hao wrote: > On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: >> Hi Grant, >> >> I observe the following boot failure with today's (next-20140220) linux-next >> tree on Exynos based boards with the default exynos_defconfig. > > Does this hel

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Kevin Hao
On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: > Hi Grant, > > I observe the following boot failure with today's (next-20140220) linux-next > tree on Exynos based boards with the default exynos_defconfig. Does this help? diff --git a/drivers/of/base.c b/drivers/of/base.c index 8a2

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
Hi Grant, I observe the following boot failure with today's (next-20140220) linux-next tree on Exynos based boards with the default exynos_defconfig. Uncompressing Linux... done, booting the kernel. [0.00] Booting Linux on physical CPU 0x900 [0.00] Linux version 3.14.0-rc3-next-20

[PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-19 Thread Grant Likely
Hi all, I've taken Kevin's latest rework and done even more rework on it. :-) I didn't quite like how it was looking so I rolled his scoring code directly into __of_device_is_compatible() so that the function always returns a score in a way that is still compatible with the existing users (ie. non