Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Hans Verkuil
On 21/07/2020 16:23, Helen Koike wrote: > Hi, > > On 7/21/20 7:24 AM, Hans Verkuil wrote: >> On 17/07/2020 13:54, Helen Koike wrote: >>> Hi, >>> >>> I'm sorry for taking too long to submit v4. >>> >>> It is not perfect, not all v4l2-compliance tests passes, but I'd like a >>> review, >>>

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Helen Koike
Hi, On 7/21/20 7:24 AM, Hans Verkuil wrote: > On 17/07/2020 13:54, Helen Koike wrote: >> Hi, >> >> I'm sorry for taking too long to submit v4. >> >> It is not perfect, not all v4l2-compliance tests passes, but I'd like a >> review, >> specially on the API and potential problems, so I can focus

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Helen Koike
Hi Boris, On 7/21/20 8:15 AM, Boris Brezillon wrote: > Hello Helen, > > Just a few drive-by comments. > > On Fri, 17 Jul 2020 08:54:29 -0300 > Helen Koike wrote: > >> Hi, >> >> I'm sorry for taking too long to submit v4. >> >> It is not perfect, not all v4l2-compliance tests passes, but I'd

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Boris Brezillon
Hello Helen, Just a few drive-by comments. On Fri, 17 Jul 2020 08:54:29 -0300 Helen Koike wrote: > Hi, > > I'm sorry for taking too long to submit v4. > > It is not perfect, not all v4l2-compliance tests passes, but I'd like a > review, > specially on the API and potential problems, so I

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-21 Thread Hans Verkuil
On 17/07/2020 13:54, Helen Koike wrote: > Hi, > > I'm sorry for taking too long to submit v4. > > It is not perfect, not all v4l2-compliance tests passes, but I'd like a > review, > specially on the API and potential problems, so I can focus on improving > implementation > and maybe drop the

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-20 Thread Helen Koike
On 7/20/20 8:57 AM, Tomasz Figa wrote: > Hi Helen, > > On Fri, Jul 17, 2020 at 1:55 PM Helen Koike wrote: >> >> Hi, >> >> I'm sorry for taking too long to submit v4. >> >> It is not perfect, not all v4l2-compliance tests passes, but I'd like a >> review, >> specially on the API and potential

Re: [PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-20 Thread Tomasz Figa
Hi Helen, On Fri, Jul 17, 2020 at 1:55 PM Helen Koike wrote: > > Hi, > > I'm sorry for taking too long to submit v4. > > It is not perfect, not all v4l2-compliance tests passes, but I'd like a > review, > specially on the API and potential problems, so I can focus on improving > implementation

[PATCH v4 0/6] media: v4l2: Add extended fmt and buffer ioctls

2020-07-17 Thread Helen Koike
Hi, I'm sorry for taking too long to submit v4. It is not perfect, not all v4l2-compliance tests passes, but I'd like a review, specially on the API and potential problems, so I can focus on improving implementation and maybe drop the RFC tag for next version. Follow below what changed in v4