Re: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device

2020-05-09 Thread Kees Cook
On Sat, May 09, 2020 at 06:32:28PM +0800, WeiXiong Liao wrote: > The following diff is to fix "rmmod" bug. > > @@ -1273,8 +1273,8 @@ static void psz_free_zones(struct pstore_zone > ***pszones, unsigned int *cnt) > return; > > while (*cnt > 0) { > - psz_free_z

Re: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device

2020-05-09 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 3:27, Kees Cook wrote: > On Thu, May 07, 2020 at 11:39:52PM -0700, Kees Cook wrote: >> So far, I've identified the following stuff left to do: >> [...] >> - implement ramoops-like probe feature for pstore/blk > > With the following hack, I'm able to start test

Re: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device

2020-05-08 Thread Kees Cook
On Thu, May 07, 2020 at 11:39:52PM -0700, Kees Cook wrote: > So far, I've identified the following stuff left to do: > [...] > - implement ramoops-like probe feature for pstore/blk With the following hack, I'm able to start testing the series: diff --git a/fs/pstore/blk.c b/fs/pstore/blk.

[PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device

2020-05-07 Thread Kees Cook
Hi! This is a v4 of WeiXiong Liao's series. I spent time porting this on top of the latest pstore (mainly to support max_reason), and I started making various other changes, mostly just bikeshed stuff. Changes since v3: fixing up various typos, alternate phrases, and language. For