Re: [PATCH v4 01/10] regmap: Introduce regmap_get_max_register.

On Mon, Mar 30, 2015 at 10:56:27PM +0100, Srinivas Kandagatla wrote: > +int regmap_get_max_register(struct regmap *map) > +{ > + return map->max_register ? : -EINVAL; > +} Please don't abuse the ternery operator like this, write a proper if statement that people can read. signature.asc

Re: [PATCH v4 01/10] regmap: Introduce regmap_get_max_register.

On Mon, Mar 30, 2015 at 10:56:27PM +0100, Srinivas Kandagatla wrote: +int regmap_get_max_register(struct regmap *map) +{ + return map-max_register ? : -EINVAL; +} Please don't abuse the ternery operator like this, write a proper if statement that people can read. signature.asc

[PATCH v4 01/10] regmap: Introduce regmap_get_max_register.

This patch introduces regmap_get_max_register() function which would be used by the infrastructures like eeprom framework built on top of regmap. Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap.c | 12 include/linux/regmap.h | 7 +++ 2 files changed, 19

[PATCH v4 01/10] regmap: Introduce regmap_get_max_register.

This patch introduces regmap_get_max_register() function which would be used by the infrastructures like eeprom framework built on top of regmap. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/base/regmap/regmap.c | 12 include/linux/regmap.h |