Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-21 Thread Matthew Wilcox
On Mon, Mar 22, 2021 at 12:52:40PM +1000, Nicholas Piggin wrote: > Excerpts from Matthew Wilcox's message of March 19, 2021 11:25 am: > > On Fri, Mar 19, 2021 at 10:56:45AM +1100, Balbir Singh wrote: > >> On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: > >> > A struct

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-21 Thread Nicholas Piggin
Excerpts from Matthew Wilcox's message of March 19, 2021 11:25 am: > On Fri, Mar 19, 2021 at 10:56:45AM +1100, Balbir Singh wrote: >> On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: >> > A struct folio refers to an entire (possibly compound) page. A function >> > which

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-19 Thread Balbir Singh
On Fri, Mar 19, 2021 at 01:25:27AM +, Matthew Wilcox wrote: > On Fri, Mar 19, 2021 at 10:56:45AM +1100, Balbir Singh wrote: > > On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: > > > A struct folio refers to an entire (possibly compound) page. A function > > > which

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-18 Thread Matthew Wilcox
On Fri, Mar 19, 2021 at 10:56:45AM +1100, Balbir Singh wrote: > On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: > > A struct folio refers to an entire (possibly compound) page. A function > > which takes a struct folio argument declares that it will operate on the > >

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-18 Thread Balbir Singh
On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: > A struct folio refers to an entire (possibly compound) page. A function > which takes a struct folio argument declares that it will operate on the > entire compound page, not just PAGE_SIZE bytes. In return, the caller >

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-17 Thread Christoph Hellwig
On Fri, Mar 05, 2021 at 04:18:37AM +, Matthew Wilcox (Oracle) wrote: > +/* > + * A struct folio is either a base (order-0) page or the head page of > + * a compound page. > + */ Hmm. While that comment seems to be true I'm not sure it is the essence. Maybe it should be more framed in terms

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-13 Thread Matthew Wilcox
On Sat, Mar 13, 2021 at 12:37:02PM -0800, Andrew Morton wrote: > On Fri, 5 Mar 2021 04:18:37 + "Matthew Wilcox (Oracle)" > wrote: > > > A struct folio refers to an entire (possibly compound) page. A function > > which takes a struct folio argument declares that it will operate on the > >

Re: [PATCH v4 01/25] mm: Introduce struct folio

2021-03-13 Thread Andrew Morton
On Fri, 5 Mar 2021 04:18:37 + "Matthew Wilcox (Oracle)" wrote: > A struct folio refers to an entire (possibly compound) page. A function > which takes a struct folio argument declares that it will operate on the > entire compound page, not just PAGE_SIZE bytes. In return, the caller >

[PATCH v4 01/25] mm: Introduce struct folio

2021-03-04 Thread Matthew Wilcox (Oracle)
A struct folio refers to an entire (possibly compound) page. A function which takes a struct folio argument declares that it will operate on the entire compound page, not just PAGE_SIZE bytes. In return, the caller guarantees that the pointer it is passing does not point to a tail page.